TwoFactorAuth plugin language reworked #19482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'. |
github-actions
bot
added
the
Stale
sgiehl
requested changes
Jul 21, 2022
plugins/TwoFactorAuth/lang/en.json
Outdated
| "TwoFactorAuthenticationIsDisabled": "Two-factor authentication is currently disabled.", | ||
| "TwoFactorAuthenticationRequired": "Two-factor authentication is required to be enabled for everyone, you cannot disable it.", | ||
| "ConfigureDifferentDevice": "Configure a different device", | ||
| "TwoFactorAuthenticationIntro": "%1$sTwo-factor authentication%2$s increase your account security by asking for an additional authentication token generated on for example a mobile device when logging in.", |
There was a problem hiding this comment.
Should we maybe keep some of the additional description, like what it means (This means that even when someone knows your username and password, they still won't be able to log in unless they have access to your mobile device for example.).
This might be obvious for people that are familiar with IT and the internet, but maybe not for people that aren't.
plugins/TwoFactorAuth/lang/en.json
Outdated
| "RequireTwoFAForAll": "Require two-factor authentication for everyone", | ||
| "RequireTwoFAForAllInformation": "When enabled, every user has to enable two factor authentication. Enforcing 2FA will require all users to have access to a device where they can install an authenticator app. You can only enable this if you already have two factor authentication set up yourself." | ||
| "RequireTwoFAForAllInformation": "Requires two-factor authentication for all users. Enforcing 2FA means all users need access to a device where they can install an OTP app. Having set up two-factor authentication for yourself first is required." |
There was a problem hiding this comment.
The first in the last part sounds a bit misplaced for me. I would remove it, or have it in the end. But if it's placed on purpose that might be fine as well.
sgiehl
added
c: i18n
comradekingu
commented
Jul 25, 2022
comradekingu
commented
Jul 25, 2022
comradekingu
commented
Jul 25, 2022
comradekingu
commented
Jul 25, 2022
comradekingu
commented
Jul 25, 2022
comradekingu
commented
Jul 25, 2022
Co-authored-by: Stefan Giehl <stefan@matomo.org>
comradekingu
commented
Jul 25, 2022
sgiehl
requested changes
Jul 26, 2022
comradekingu
commented
Jul 27, 2022
comradekingu
commented
Jul 27, 2022
comradekingu
commented
Jul 27, 2022
sgiehl
reviewed
Jul 28, 2022
Co-authored-by: Stefan Giehl <stefan@matomo.org>
comradekingu
commented
Jul 28, 2022
sgiehl
reviewed
Jul 29, 2022
sgiehl
approved these changes
Jul 29, 2022
sgiehl
added a commit
that referenced
this pull request
Aug 2, 2022
* Live plugin language reworked (#19438) * Live plugin language reworked * Sentence casing Co-authored-by: Stefan Giehl <stefan@matomo.org> * Visited earlier, subcategories * Reverted to "visits log" * RowActionTooltipWithDimension reverted Co-authored-by: Stefan Giehl <stefan@matomo.org> * Update plugins/Live/lang/en.json Co-authored-by: Stefan Giehl <stefan@matomo.org> * updates expected test files * Tour pluging language reworked (#19499) * updates expected test files * Transitions plugin language reworked (#19497) * Transitions plugin language reworked * Suggested changes made Co-authored-by: Stefan Giehl <stefan@matomo.org> * Launch transitions sentence Co-authored-by: Stefan Giehl <stefan@matomo.org> * UserCountry plugin language reworked (#19479) * UserCountry plugin language reworked * Suggested changes and fixes Co-authored-by: Stefan Giehl <stefan@matomo.org> * Deduplication * Steps for accurate geolocation Co-authored-by: Stefan Giehl <stefan@matomo.org> * TwoFactorAuth plugin language reworked (#19482) * TwoFactorAuth plugin language reworked * Suggested changes and clarifications made Co-authored-by: Stefan Giehl <stefan@matomo.org> * Avoiding misinterpretations * Clarifications * Spelling: your old codes Co-authored-by: Stefan Giehl <stefan@matomo.org> * prerequisite * - log in Co-authored-by: Stefan Giehl <stefan@matomo.org> Co-authored-by: Stefan Giehl <stefan@matomo.org> * fix syntax * updates expected test files * fix placeholder Co-authored-by: Allan Nordhøy <epost@anotheragency.no>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Generally shorter and to the point.
In line with other edits.
Review