New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UserCountry plugin language reworked #19479
Merged
sgiehl
merged 4 commits into
matomo-org:translationimprovements
from
comradekingu:patch-18
Jul 29, 2022
Merged
UserCountry plugin language reworked #19479
sgiehl
merged 4 commits into
matomo-org:translationimprovements
from
comradekingu:patch-18
Jul 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comradekingu
commented
Jul 6, 2022
comradekingu
commented
Jul 6, 2022
sgiehl
reviewed
Jul 8, 2022
Co-authored-by: Stefan Giehl <stefan@matomo.org>
sgiehl
added
the
c: i18n
For issues around internationalisation and localisation.
label
Jul 21, 2022
sgiehl
requested changes
Jul 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left two suggestions, otherwise looks good so far.
comradekingu
commented
Jul 27, 2022
comradekingu
commented
Jul 28, 2022
sgiehl
approved these changes
Jul 29, 2022
sgiehl
added a commit
that referenced
this pull request
Aug 2, 2022
* Live plugin language reworked (#19438) * Live plugin language reworked * Sentence casing Co-authored-by: Stefan Giehl <stefan@matomo.org> * Visited earlier, subcategories * Reverted to "visits log" * RowActionTooltipWithDimension reverted Co-authored-by: Stefan Giehl <stefan@matomo.org> * Update plugins/Live/lang/en.json Co-authored-by: Stefan Giehl <stefan@matomo.org> * updates expected test files * Tour pluging language reworked (#19499) * updates expected test files * Transitions plugin language reworked (#19497) * Transitions plugin language reworked * Suggested changes made Co-authored-by: Stefan Giehl <stefan@matomo.org> * Launch transitions sentence Co-authored-by: Stefan Giehl <stefan@matomo.org> * UserCountry plugin language reworked (#19479) * UserCountry plugin language reworked * Suggested changes and fixes Co-authored-by: Stefan Giehl <stefan@matomo.org> * Deduplication * Steps for accurate geolocation Co-authored-by: Stefan Giehl <stefan@matomo.org> * TwoFactorAuth plugin language reworked (#19482) * TwoFactorAuth plugin language reworked * Suggested changes and clarifications made Co-authored-by: Stefan Giehl <stefan@matomo.org> * Avoiding misinterpretations * Clarifications * Spelling: your old codes Co-authored-by: Stefan Giehl <stefan@matomo.org> * prerequisite * - log in Co-authored-by: Stefan Giehl <stefan@matomo.org> Co-authored-by: Stefan Giehl <stefan@matomo.org> * fix syntax * updates expected test files * fix placeholder Co-authored-by: Allan Nordhøy <epost@anotheragency.no>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Generally shorter and to the point.
In line with other edits.
Review