Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UserCountry plugin language reworked #19479

Merged
merged 4 commits into from Jul 29, 2022

Conversation

comradekingu
Copy link
Contributor

Description:

Generally shorter and to the point.
In line with other edits.

Review

Co-authored-by: Stefan Giehl <stefan@matomo.org>
@sgiehl sgiehl added the c: i18n For issues around internationalisation and localisation. label Jul 21, 2022
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left two suggestions, otherwise looks good so far.

plugins/UserCountry/lang/en.json Outdated Show resolved Hide resolved
plugins/UserCountry/lang/en.json Outdated Show resolved Hide resolved
@sgiehl sgiehl changed the base branch from 4.x-dev to translationimprovements July 29, 2022 08:59
@sgiehl sgiehl merged commit f8eddcb into matomo-org:translationimprovements Jul 29, 2022
sgiehl added a commit that referenced this pull request Aug 2, 2022
* Live plugin language reworked (#19438)

* Live plugin language reworked

* Sentence casing

Co-authored-by: Stefan Giehl <stefan@matomo.org>

* Visited earlier, subcategories

* Reverted to "visits log"

* RowActionTooltipWithDimension reverted

Co-authored-by: Stefan Giehl <stefan@matomo.org>

* Update plugins/Live/lang/en.json

Co-authored-by: Stefan Giehl <stefan@matomo.org>

* updates expected test files

* Tour pluging language reworked (#19499)

* updates expected test files

* Transitions plugin language reworked (#19497)

* Transitions plugin language reworked

* Suggested changes made

Co-authored-by: Stefan Giehl <stefan@matomo.org>

* Launch transitions sentence

Co-authored-by: Stefan Giehl <stefan@matomo.org>

* UserCountry plugin language reworked (#19479)

* UserCountry plugin language reworked

* Suggested changes and fixes

Co-authored-by: Stefan Giehl <stefan@matomo.org>

* Deduplication

* Steps for accurate geolocation

Co-authored-by: Stefan Giehl <stefan@matomo.org>

* TwoFactorAuth plugin language reworked (#19482)

* TwoFactorAuth plugin language reworked

* Suggested changes and clarifications made

Co-authored-by: Stefan Giehl <stefan@matomo.org>

* Avoiding misinterpretations

* Clarifications

* Spelling: your old codes

Co-authored-by: Stefan Giehl <stefan@matomo.org>

* prerequisite

* - log in

Co-authored-by: Stefan Giehl <stefan@matomo.org>

Co-authored-by: Stefan Giehl <stefan@matomo.org>

* fix syntax

* updates expected test files

* fix placeholder

Co-authored-by: Allan Nordhøy <epost@anotheragency.no>
@sgiehl sgiehl added this to the 4.11.1 milestone May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: i18n For issues around internationalisation and localisation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants