New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[js]Update * to originHost #19471
[js]Update * to originHost #19471
Conversation
update * to originHost
# Conflicts: # js/piwik.min.js # matomo.js # piwik.js
update protocol
Co-authored-by: Stefan Giehl <stefan@matomo.org>
build js |
The code changes are looking ok. |
# Conflicts: # js/piwik.min.js # matomo.js # piwik.js
update merge
ping @peterhashair this is waiting for your reply to @sgiehl to help him review this effectively. |
@sgiehl @justinvelluppillai ops, sorry, I think there is js test for it, which is that one. matomo/tests/javascript/index.php Line 5219 in a8dec66
But to tests locally. I add this to my addEventListener('load', (event) => {
const targetFrame = window.top.frames[0];
const targetOrigin = 'https://yourtrackingsite';
targetFrame.postMessage('{"d":"hello there","maq_initial_value":true}', targetOrigin);
}); |
@peterhashair the PR contains two added files, that shouldn't exist. |
@sgiehl ops, that was accidentally added, removed. |
Description:
Fixes: #19358
Only fix apply issue 1 fixes. update * to
originHost
. It seems e.origin contain protocol already.Review