UsersManager plugin language reworked #19469
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comradekingu
commented
Jul 5, 2022
| "ForAnonymousUsersReportDateToLoadByDefault": "For anonymous users, report date to load by default", | ||
| "GiveUserAccess": "Give '%1$s' %2$s access for %3$s.", | ||
| "GiveViewAccess": "Give view access for %1$s", | ||
| "ExceptionPasswordMD5HashExpected": "UsersManager.getTokenAuth is expecting an MD5-hashed password (a string of 32 characters). Please call the md5() function on the password before calling this method.", |
sgiehl
reviewed
Jul 6, 2022
| "CreateNewToken": "Create new token", | ||
| "AnonymousAccessConfirmation": "You are about to grant the anonymous user the 'view' access to this website. This means your analytics reports and your visitors information will be publicly viewable by anyone even without a login. Are you sure you want to proceed?", | ||
| "AnonymousAccessConfirmation": "Grant the anonymous user the 'view' access to this website? This means your analytics reports and your visitor will be publicly viewable by anyone even without a login.", |
There was a problem hiding this comment.
Shouldn't it still say something like visitor info or visitor details?
sgiehl
reviewed
Jul 6, 2022
| "ConfirmGrantSuperUserAccess": "Grant '%s' superuser access? Warning: The user will have access to all websites and will be able to perform administrative tasks.", | ||
| "ConfirmProhibitMySuperUserAccess": "%s, do you really want to remove your own superuser access? You will lose all permissions and access to all websites, and will be logged out of Matomo.", | ||
| "ConfirmProhibitOtherUsersSuperUserAccess": "Revoke superuser access from '%s'? The user will lose all permissions and access to all websites. Make sure you grant access to needed websites afterwards if necessary.", | ||
| "DeleteConfirm": "Delete the '%s' user?", |
There was a problem hiding this comment.
The placeholder will be filled with the users login. Not sure if the order needs to be changed in that case.
sgiehl
reviewed
Jul 6, 2022
| "ExceptionInvalidPasswordTooLong": "The password length must be less than %1$s characters.", | ||
| "ExceptionAnonymousAccessNotPossible": "You can only set %1$s or %2$s access for the 'anonymous' user.", | ||
| "ExceptionDeleteDoesNotExist": "The user '%s' doesn't exist, and therefore can't be deleted.", | ||
| "ExceptionDeleteOnlyUserWithSuperUserAccess": "Deleting the '%s' user is not possible.", |
sgiehl
reviewed
Jul 6, 2022
| "ExceptionRemoveSuperUserAccessOnlySuperUser": "Revoking superuser access for the user '%s' is not possible.", | ||
| "ExceptionSuperUserAccess": "This user has superuser access and already has permission to access and modify all websites in Matomo. You may revoke superuser access for this user and try again.", | ||
| "ExceptionUserHasSuperUserAccess": "The user '%s' has superuser access and already has permission to access and modify all websites in Matomo. You may revoke superuser access for this user and try again.", | ||
| "ExceptionUserDoesNotExist": "There is no '%s' user.", |
There was a problem hiding this comment.
here the placeholder is filled with the login as well
sgiehl
reviewed
Jul 6, 2022
sgiehl
reviewed
Jul 6, 2022
comradekingu
commented
Jul 6, 2022
sgiehl
reviewed
Jul 6, 2022
comradekingu
commented
Jul 6, 2022
comradekingu
commented
Jul 6, 2022
comradekingu
commented
Jul 6, 2022
sgiehl
reviewed
Jul 6, 2022
| "UsersManagementMainDescription": "Create new users or update the existing users. You can then set their permissions above.", | ||
| "WhenUsersAreNotLoggedInAndVisitPiwikTheyShouldAccess": "When users are not logged in and visit Matomo, they should initially see", | ||
| "WhenUsersAreNotLoggedInAndVisitPiwikTheyShouldAccess": "When users are not logged in and visit Matomo, they should initially be met by", |
There was a problem hiding this comment.
This one is displayed in this context:
Not sure if the new wording fits there.
There was a problem hiding this comment.
Should be "The dashboard for all websites" and "A dashboard for a specific website", but that mostly remains the same with "see".
sgiehl
reviewed
Jul 6, 2022
| "ManageUsersAdminDesc": "Create new users or update the existing users. You can then set their permissions here too. Please note that you are logged in as an administrator. This means you only see and manage users that have access to the specific websites where you have \"admin\" permissions. Only a user with super user access can see and manage all users across all websites.", | ||
| "NoAccessWarning": "This user has not been granted access to a website. When they login, they will see an error message. To prevent this, add access to a website below.", | ||
| "ManageUsersAdminDesc": "Create new users or update existing ones and their permissions. As you are logged in as an administrator you only browse and manage users that have access to the specific websites where you have \"admin\" permissions. Only a user with superuser access can browse and manage all users across all websites.", | ||
| "NoAccessWarning": "This user has not been granted access to a website and will get an error message when logging in. Prevent this by granting access to a website below.", |
There was a problem hiding this comment.
Is this maybe better?
Suggested change
| "NoAccessWarning": "This user has not been granted access to a website and will get an error message when logging in. Prevent this by granting access to a website below.", | |
| "NoAccessWarning": "This user has not been granted access to any website and will get an error message when logging in. Prevent this by granting access to a website below.", |
sgiehl
reviewed
Jul 6, 2022
sgiehl
reviewed
Jul 6, 2022
sgiehl
reviewed
Jul 6, 2022
sgiehl
reviewed
Jul 6, 2022
| "PasswordChangeNotificationSubject": "Your Matomo account's password has just been changed", | ||
| "PasswordChangedEmail": "Your password has just been changed. The change was initiated from the following device: %1$s (IP address = %2$s).", | ||
| "PasswordChangeTerminatesOtherSessions": "When you change your password, any other active session of this account will be logged out.", | ||
| "PasswordChangedEmail": "Your password has just been changed. The change was initiated from the following device: %1$s (IP address — %2$s).", |
There was a problem hiding this comment.
The second placeholder is filled with the ip-adress. So wouldn't it be better to use a : instead of —?
comradekingu
commented
Jul 6, 2022
comradekingu
commented
Jul 6, 2022
comradekingu
commented
Jul 6, 2022
|
@comradekingu Any reason for including the UserId stuff here? Wasn't that included in another PR already? |
|
@sgiehl Just tired. Will get that fixed. |
* WebsiteMeasurable plugin language reworked (matomo-org#19444) * WebsiteMeasurable plugin language reworked * comma * update tests * VisitTime plugin language reworked (matomo-org#19453) * VisitTime plugin language reworked * Spelling: technical Co-authored-by: Stefan Giehl <stefan@matomo.org> Co-authored-by: Stefan Giehl <stefan@matomo.org> * VisitorInterest plugin language reworked (matomo-org#19445) * VisitorInterest plugin language reworked * Spelling: their Co-authored-by: Stefan Giehl <stefan@matomo.org> Co-authored-by: Stefan Giehl <stefan@matomo.org> * update tests Co-authored-by: Allan Nordhøy <epost@anotheragency.no>
|
@comradekingu There had been a couple of changes the the usersmanager language. Not sure if you are able to rebase this PR. Otherwise might maybe be simpler to recreate the PR with your changes. |
|
If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'. |
github-actions
bot
added
the
Stale
|
This PR was last updated more than one month ago, maybe it's time to close it. Please check if there is anything we still can do or close this PR. ping @matomo-org/core-reviewers |
github-actions
bot
added
the
Stale for long
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Generally shorter and to the point.
In line with other edits.
Review