Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VisitFrequency plugin language reworked #19467

Open
wants to merge 2 commits into
base: 4.x-dev
Choose a base branch
from
Open

VisitFrequency plugin language reworked #19467

wants to merge 2 commits into from

Conversation

comradekingu
Copy link
Contributor

Description:

Generally shorter and to the point.
In line with other edits.

Can't get to what I think is the relevant UI parts without an account, but alas.
Visits aren't the thing that returns, as they have to be separate events to be returning.
Similarly, visitors (as opposed to visits) carry out actions.

Review

@sgiehl sgiehl added the c: i18n For issues around internationalisation and localisation. label Jul 6, 2022
@github-actions
Copy link
Contributor

If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'.

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Jul 21, 2022
@sgiehl sgiehl removed the Stale The label used by the Close Stale Issues action label Jul 21, 2022
@sgiehl
Copy link
Member

sgiehl commented Jul 21, 2022

I'm in general not sure if changing new/returning visits into new/returning visitors is fully correct. Looking at the language only this might sound better. But technically that is a difference I guess. If e.g. someone visited a page yesterday and comes back today twice, that would mean there was one returning visitor, but actually two returning visits. 🤔

@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2022

If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'.

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Aug 5, 2022
comradekingu
comradekingu commented Aug 5, 2022
View reviewed changes
plugins/VisitFrequency/lang/en.json
"ColumnAverageVisitDurationForNewVisitors": "Avg. amount of seconds spent by new visitors",
"ColumnAverageVisitDurationForReturningVisitors": "Avg. amount of seconds spent by returning visitors",
"ColumnAvgActionsPerNewVisit": "Avg. actions per new visitor",
"ColumnAvgActionsPerReturningVisit": "Avg. actions per returning visitor",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potentially misleading

comradekingu
comradekingu commented Aug 5, 2022
View reviewed changes
plugins/VisitFrequency/lang/en.json
"ColumnBounceRateForNewVisits": "Bounce rate for new visitors",
"ColumnBounceRateForReturningVisits": "Bounce rate for returning visitors",
"ColumnMaxActionsInReturningVisit": "Max actions in one returning visit",
"ColumnNbReturningVisitsConverted": "Number of converted returning visitors",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"ColumnNbReturningVisitsConverted": "Number of converted returning visitors",
"ColumnNbReturningVisitsConverted": "Number of converted visits made by returning visitors",

comradekingu
comradekingu commented Aug 5, 2022
View reviewed changes
plugins/VisitFrequency/lang/en.json
"PluginDescription": "Reports metrics about your returning and (first time) new visitors.",
"ReturnActions": "actions by the returning visitors",
"ReturnAverageVisitDuration": "avg. time spent by returning visitors calculated from each of their visists",
"ReturnAvgActions": "actions per returning visitor",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"ReturnAvgActions": "actions per returning visitor",
"ReturnAvgActions": "actions per visit for returning visitors",

@github-actions
Copy link
Contributor

This PR was last updated more than one month ago, maybe it's time to close it. Please check if there is anything we still can do or close this PR. ping @matomo-org/core-reviewers

@github-actions github-actions bot added the Stale for long The label used by the Close Stale Issues action label Sep 17, 2022
@mattab mattab mentioned this pull request Dec 11, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl left review comments

Assignees
No one assigned
Labels
c: i18n For issues around internationalisation and localisation. Stale for long The label used by the Close Stale Issues action Stale The label used by the Close Stale Issues action
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@comradekingu @sgiehl