Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vue] do not propagate class & style vue entry #19457

Merged
merged 1 commit into from Jul 4, 2022

Conversation

diosmosis
Copy link
Member

Description:

"entry" components should be self-contained, avoiding the propagation css class/styles allows styling the containing element w/o accidentally affecting the vue component.

Review

@diosmosis diosmosis added the Needs Review PRs that need a code review label Jul 3, 2022
@diosmosis diosmosis added this to the 4.12.0 milestone Jul 3, 2022
@diosmosis diosmosis force-pushed the vue-do-not-propagate-class-vue-entry branch from 0fbae62 to f387a76 Compare July 3, 2022 19:25
@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. and removed Needs Review PRs that need a code review labels Jul 4, 2022
@sgiehl sgiehl merged commit fead960 into 4.x-dev Jul 4, 2022
@sgiehl sgiehl deleted the vue-do-not-propagate-class-vue-entry branch July 4, 2022 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants