Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes icon-menu-hamburger size #19456

Merged
merged 1 commit into from Jul 5, 2022

Conversation

ulcuber
Copy link
Contributor

@ulcuber ulcuber commented Jul 1, 2022

Description:

Expected:

image

image

Actual:

image

image

Review

@sgiehl
Copy link
Member

sgiehl commented Jul 4, 2022

@ulcuber would you mind to explain when the icon is displayed in an incorrect size? Does that happen in a specific browser only, or only on certain screen sizes or zoom levels? For me it seems to look fine 🤔

@ulcuber
Copy link
Contributor Author

ulcuber commented Jul 4, 2022

@sgiehl
Sorry for being unclear.

As nav .icon-more-verti, nav .icon-menu-hamburger {font-size: 2.7rem} based on reasonable font size (html font size or browser fonts settings) it could be any configured by user.

Overflow occurs at least on sizes <=600px
From Materialize: nav {height: 56px; line-height: 56px;}
56px < 2.7rem on default setting:

image

If user uses increased fonts then even worse:

image

On wider screen applied this:

@media only screen and (min-width: 601px) {
nav, nav .nav-wrapper i, nav a.sidenav-trigger, nav a.sidenav-trigger i {
    height: 64px;
    line-height: 64px;
}
}

making it less visible but still visible when fonts increased:

image

@sgiehl sgiehl added the Needs Review PRs that need a code review label Jul 4, 2022
Copy link
Contributor

@peterhashair peterhashair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

working as expected after browser font size increase to the max, 2 screenshots needs update.

@sgiehl sgiehl added the c: Design / UI For issues that impact Matomo's user interface or the design overall. label Jul 5, 2022
@sgiehl sgiehl added this to the 4.12.0 milestone Jul 5, 2022
@sgiehl sgiehl merged commit 8a5165e into matomo-org:4.x-dev Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall. Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants