@ulcuber opened this Pull Request on July 1st 2022 Contributor

Description:

Expected:

image

image

Actual:

image

image

Review

@sgiehl commented on July 4th 2022 Member

@ulcuber would you mind to explain when the icon is displayed in an incorrect size? Does that happen in a specific browser only, or only on certain screen sizes or zoom levels? For me it seems to look fine 🤔

@ulcuber commented on July 4th 2022 Contributor

@sgiehl
Sorry for being unclear.

As nav .icon-more-verti, nav .icon-menu-hamburger {font-size: 2.7rem} based on reasonable font size (html font size or browser fonts settings) it could be any configured by user.

Overflow occurs at least on sizes <=600px
From Materialize: nav {height: 56px; line-height: 56px;}
56px < 2.7rem on default setting:

image

If user uses increased fonts then even worse:

image

On wider screen applied this:

<a class='mention' href='https://github.com/media'>@media</a> only screen and (min-width: 601px) {
nav, nav .nav-wrapper i, nav a.sidenav-trigger, nav a.sidenav-trigger i {
    height: 64px;
    line-height: 64px;
}
}

making it less visible but still visible when fonts increased:

image

This Pull Request was closed on July 5th 2022
Powered by GitHub Issue Mirror