Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes too large buttons padding for mobile #19455

Closed
wants to merge 1 commit into from
Closed

Fixes too large buttons padding for mobile #19455

wants to merge 1 commit into from

Conversation

ulcuber
Copy link
Contributor

@ulcuber ulcuber commented Jul 1, 2022 •
edited

Description:

Actual

image

Expected

image

How to build plugin Morpheus?

Review

@justinvelluppillai justinvelluppillai added the Needs Review PRs that need a code review label Jul 4, 2022
@sgiehl
Copy link
Member

sgiehl commented Jul 4, 2022

@ulcuber building *.less files isn't needed. Those are parsed on the fly. It's only needed to build with changes to vue related files.

sgiehl
sgiehl requested changes Jul 4, 2022
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ulcuber Your changes are producing a couple of regression in the button width. See e.g.
https://builds-artifacts.matomo.org/matomo-org/matomo/4.x-dev/57310/Menus_mobile_top.png
or
https://builds-artifacts.matomo.org/matomo-org/matomo/4.x-dev/57310/DashboardManager_small_screen.png

It seems you are trying to fix some specific buttons. If that's the case it might be better to apply changes to those specific button maybe, so when can avoid changes anywhere else.

@sgiehl sgiehl added Waiting for user feedback Indicates the Matomo team is waiting for feedback from the author or other users. and removed Needs Review PRs that need a code review labels Jul 4, 2022
@ulcuber ulcuber mentioned this pull request Jul 4, 2022
Merged
11 tasks
@ulcuber
Copy link
Contributor Author

ulcuber commented Jul 4, 2022

@sgiehl Yes, this one too bad.
More specific: matomo-org/tag-manager#508

@sgiehl
Copy link
Member

sgiehl commented Jul 4, 2022

@ulcuber Nice. Can we close this PR then?

@ulcuber
Copy link
Contributor Author

ulcuber commented Jul 4, 2022

@sgiehl Yes. Close this PR.

@ulcuber ulcuber closed this Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl requested changes

Assignees
No one assigned
Labels
Waiting for user feedback Indicates the Matomo team is waiting for feedback from the author or other users.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ulcuber @sgiehl @justinvelluppillai