@ulcuber opened this Pull Request on July 1st 2022 Contributor

Description:

Allows configure full width field through template parameters.

plugins/CorePluginsAdmin/vue/src/FormField/FormField.vue already have this ability but it used only in frontend.

As FieldMultituple allows to use up to 4 subfields, it would be nice to have ability to extend it to full width.

Review

@sgiehl commented on July 4th 2022 Member

@ulcuber would you mind updating our theme demo page and change or add an entry to it shows a full width multituple?
https://github.com/matomo-org/matomo/blob/4b59d5f56af5eb40e04bed7fdeb795f14d09554c/plugins/Morpheus/templates/demo.twig#L350-L363
This will then reflect in our UI tests and prevent future regressions of this change.
The page can be viewed at Development > UI Demo

@ulcuber commented on July 4th 2022 Contributor

@sgiehl added demo

@sgiehl commented on July 5th 2022 Member

@ulcuber There are a lot tests failing now. If you want, feel free to try fixing them. Otherwise we can also do that once, the changes have been reviewed and approved.

@github-actions[bot] commented on July 13th 2022 Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

This Pull Request was closed on July 15th 2022
Powered by GitHub Issue Mirror