@ulcuber
Description:
Allows configure full width field through template parameters.
plugins/CorePluginsAdmin/vue/src/FormField/FormField.vue already have this ability but it used only in frontend.
As FieldMultituple allows to use up to 4 subfields, it would be nice to have ability to extend it to full width.
Review
- [ ] Functional review done
- [ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
- [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
- [ ] Security review done
- [ ] Wording review done
- [ ] Code review done
- [ ] Tests were added if useful/possible
- [ ] Reviewed for breaking changes
- [ ] Developer changelog updated if needed
- [ ] Documentation added if needed
- [ ] Existing documentation updated if needed
@sgiehl
@ulcuber would you mind updating our theme demo page and change or add an entry to it shows a full width multituple?
https://github.com/matomo-org/matomo/blob/4b59d5f56af5eb40e04bed7fdeb795f14d09554c/plugins/Morpheus/templates/demo.twig#L350-L363
This will then reflect in our UI tests and prevent future regressions of this change.
The page can be viewed at Development > UI Demo
@ulcuber There are a lot tests failing now. If you want, feel free to try fixing them. Otherwise we can also do that once, the changes have been reviewed and approved.
@github-actions[bot]
This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers