Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Full width field in settings #19454

Merged
merged 3 commits into from Jul 15, 2022
Merged

Full width field in settings #19454

merged 3 commits into from Jul 15, 2022

Conversation

ulcuber
Copy link
Contributor

@ulcuber ulcuber commented Jul 1, 2022

Description:

Allows configure full width field through template parameters.

plugins/CorePluginsAdmin/vue/src/FormField/FormField.vue already have this ability but it used only in frontend.

As FieldMultituple allows to use up to 4 subfields, it would be nice to have ability to extend it to full width.

Review

@sgiehl
Copy link
Member

sgiehl commented Jul 4, 2022

@ulcuber would you mind updating our theme demo page and change or add an entry to it shows a full width multituple?

matomo/plugins/Morpheus/templates/demo.twig

Lines 350 to 363 in 4b59d5f

<div piwik-field uicontrol="multituple" name="multitupletext"
data-title="Multiple values (two)"
value="[]"
inline-help="Multi Tuple text and text"
ui-control-attributes='{"field1":{"key":"index","title":"Index","uiControl":"text","availableValues":null},"field2":{"key":"value","title":"Value","uiControl":"text","availableValues":null}}'>
</div>
<div piwik-field uicontrol="multituple" name="multitupletextvalue"
data-title="Multiple values with values (two)"
value='[{"index": "test", "value":"myfoo"},{"index": "test 2", "value":"myfoo 2"}]'
inline-help="Multi Tuple again."
ui-control-attributes='{"field1":{"key":"index","title":"Index","uiControl":"text","availableValues":null},"field2":{"key":"value","title":"Value","uiControl":"text","availableValues":null}}'>
</div>

This will then reflect in our UI tests and prevent future regressions of this change.
The page can be viewed at Development > UI Demo

@sgiehl sgiehl added the Waiting for user feedback Indicates the Matomo team is waiting for feedback from the author or other users. label Jul 4, 2022
@ulcuber
Copy link
Contributor Author

ulcuber commented Jul 4, 2022

@sgiehl added demo

@sgiehl sgiehl added Needs Review PRs that need a code review and removed Waiting for user feedback Indicates the Matomo team is waiting for feedback from the author or other users. labels Jul 5, 2022
@sgiehl
Copy link
Member

sgiehl commented Jul 5, 2022

@ulcuber There are a lot tests failing now. If you want, feel free to try fixing them. Otherwise we can also do that once, the changes have been reviewed and approved.

@github-actions
Copy link
Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Jul 13, 2022
@sgiehl sgiehl added this to the 4.12.0 milestone Jul 15, 2022
@sgiehl sgiehl removed the Stale The label used by the Close Stale Issues action label Jul 15, 2022
sgiehl
sgiehl approved these changes Jul 15, 2022
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ulcuber for this improvement 🎉
The changes are looking fine so far. I'll fix the tests after merging.

@sgiehl sgiehl merged commit 82f5def into matomo-org:4.x-dev Jul 15, 2022
@sgiehl sgiehl removed the Needs Review PRs that need a code review label Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.12.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ulcuber @sgiehl