Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vue] remove angularjs from CoreVisualizations plugin #19449

Merged
merged 24 commits into from Aug 11, 2022

Conversation

diosmosis
Copy link
Member

Description:

This PR is based off of #19391.

Changes:

  • Remove use of angularjs services from vanilla JS files.
  • Remove angularjs => vue adapters.
  • Remove use of angularjs directives from twig templates and php files.

Review

@diosmosis diosmosis added this to the 5.0.0 milestone Jul 1, 2022
@diosmosis diosmosis marked this pull request as draft July 1, 2022 03:24
@diosmosis diosmosis added the Needs Review PRs that need a code review label Jul 11, 2022
@diosmosis diosmosis marked this pull request as ready for review July 11, 2022 05:15
@github-actions
Copy link
Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Jul 19, 2022
@diosmosis diosmosis added the Do not close PRs with this label won't be marked as stale by the Close Stale Issues action label Jul 19, 2022
@github-actions github-actions bot removed the Stale The label used by the Close Stale Issues action label Jul 20, 2022
@github-actions
Copy link
Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions github-actions bot added Stale The label used by the Close Stale Issues action and removed Stale The label used by the Close Stale Issues action labels Jul 28, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2022

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions github-actions bot added Stale The label used by the Close Stale Issues action and removed Stale The label used by the Close Stale Issues action labels Aug 5, 2022
@sgiehl sgiehl merged commit b5a2815 into 5.x-dev Aug 11, 2022
@sgiehl sgiehl deleted the vue-remove-angularjs-CoreVisualizations branch August 11, 2022 12:39
@justinvelluppillai justinvelluppillai added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Sep 29, 2022
bx80 pushed a commit that referenced this pull request Nov 25, 2022
* remove use of angularjs from SegmentEditor plugin

* remove import added by phpstorm

* make sure to export comparison service instance not just class

* built vue files

* remove use of angularjs from CoreVisualizations plugin

* built vue files

* fixing some issues

* fix initial value for segment definition

* treat null, undefined and empty string segment value the same

* Update expected screenshots

* try to fix timing error in test

* Allow composer plugins for dev dependency codesniffer to fix travis builds.

* fix html attribute output for singlemetricview

* remove use of html_attr escape

* remove unused use statement

Co-authored-by: sgiehl <stefan@matomo.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Do not close PRs with this label won't be marked as stale by the Close Stale Issues action Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants