Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes different height of selectors #19446

Merged
merged 1 commit into from Jul 4, 2022
Merged

Fixes different height of selectors #19446

merged 1 commit into from Jul 4, 2022

Conversation

ulcuber
Copy link
Contributor

@ulcuber ulcuber commented Jun 30, 2022 •
edited

Description:

Actual:

Selectors icons use relative values line-height: 1em while titles use absolute line-height: 12px

image

Expected:

No mixing relative and absolute heights

image

Context:

chrome://settings/fonts

Standard font size could have any value comfortable to user:

image

Review

@sgiehl sgiehl added this to the 4.12.0 milestone Jul 4, 2022
sgiehl
sgiehl approved these changes Jul 4, 2022
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't seem to regress in any UI test, so should imho be good to merge.

@sgiehl sgiehl added the c: Design / UI For issues that impact Matomo's user interface or the design overall. label Jul 4, 2022
@sgiehl sgiehl merged commit 0562dce into matomo-org:4.x-dev Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees

@ulcuber ulcuber

Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall.
Projects
None yet
Milestone
4.12.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ulcuber @sgiehl