New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Vue] remove angularjs from Dashboard plugin #19442
Conversation
…o-org/matomo into vue-remove-angularjs-SegmentEditor
…angularjs-Dashboard
…g/matomo into vue-remove-angularjs-Dashboard
…ove calls in CoreHome PR)
This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers |
This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers |
This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a look at the code changes and clicked through the UI. Couldn't find any issues so far. Tests are also passing.
* remove use of angularjs from SegmentEditor plugin * remove import added by phpstorm * make sure to export comparison service instance not just class * built vue files * remove angularjs from Dashboard plugin * built vue files * fixing some issues * fix initial value for segment definition * treat null, undefined and empty string segment value the same * Update expected screenshots * try to fix timing error in test * Allow composer plugins for dev dependency codesniffer to fix travis builds. * get to load in UI * getting dashboard settings control to work * fixing UI test issues, reintroduce compileAngularComponents (will remove calls in CoreHome PR) * fixing some more issues * hide the dashboard manager on initial display as before * update expected screenshots * fixing DashboardManager UI test that previously used the uiControlObject property * fix race condition in dashboard ajax requests/aborts * remove duplicate translation * remove use of html_attr escape * remove unused use statements * fix shown entity id in reporting menu Co-authored-by: sgiehl <stefan@matomo.org>
Description:
This PR depends on #19391.
Changes:
Review