@diosmosis opened this Pull Request on June 29th 2022 Member

Description:

This PR depends on #19391.

Changes:

  • Remove DashboardSettingsControl.php and replace w/ DashboardSettings Vue component.
  • Remove use of angularjs in twig templates
  • Remove use of angular services in vanilla JS files (no longer allowing angularjs in widget html, so this PR may cause some regressions).
  • Allow specifying a onClosed() function to ExpandOnClick to execute custom logic when a dropdown is closed.
  • Allow specifying more custom options for Tooltips directive.

Review

@github-actions[bot] commented on July 19th 2022 Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions[bot] commented on July 28th 2022 Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions[bot] commented on August 5th 2022 Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

This Pull Request was closed on August 11th 2022
Powered by GitHub Issue Mirror