New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Live plugin language reworked #19438
Live plugin language reworked #19438
Conversation
Co-authored-by: Stefan Giehl <stefan@matomo.org>
This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left another few comments. Besides them it looks good.
Co-authored-by: Stefan Giehl <stefan@matomo.org>
Merging this one into another branch to fix the tests. I will merge it to |
* Live plugin language reworked (#19438) * Live plugin language reworked * Sentence casing Co-authored-by: Stefan Giehl <stefan@matomo.org> * Visited earlier, subcategories * Reverted to "visits log" * RowActionTooltipWithDimension reverted Co-authored-by: Stefan Giehl <stefan@matomo.org> * Update plugins/Live/lang/en.json Co-authored-by: Stefan Giehl <stefan@matomo.org> * updates expected test files * Tour pluging language reworked (#19499) * updates expected test files * Transitions plugin language reworked (#19497) * Transitions plugin language reworked * Suggested changes made Co-authored-by: Stefan Giehl <stefan@matomo.org> * Launch transitions sentence Co-authored-by: Stefan Giehl <stefan@matomo.org> * UserCountry plugin language reworked (#19479) * UserCountry plugin language reworked * Suggested changes and fixes Co-authored-by: Stefan Giehl <stefan@matomo.org> * Deduplication * Steps for accurate geolocation Co-authored-by: Stefan Giehl <stefan@matomo.org> * TwoFactorAuth plugin language reworked (#19482) * TwoFactorAuth plugin language reworked * Suggested changes and clarifications made Co-authored-by: Stefan Giehl <stefan@matomo.org> * Avoiding misinterpretations * Clarifications * Spelling: your old codes Co-authored-by: Stefan Giehl <stefan@matomo.org> * prerequisite * - log in Co-authored-by: Stefan Giehl <stefan@matomo.org> Co-authored-by: Stefan Giehl <stefan@matomo.org> * fix syntax * updates expected test files * fix placeholder Co-authored-by: Allan Nordhøy <epost@anotheragency.no>
Description:
Generally shorter and to the point.
In line with other edits.
Review