Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insights plugin language reworked #19437

Open
wants to merge 4 commits into
base: 5.x-dev
Choose a base branch
from

Conversation

comradekingu
Copy link
Contributor

Description:

Generally shorter and to the point.
In line with other edits.

Review

"OverviewWidgetTitle": "Insights Overview",
"TitleConsideredInsightsChanges": "The rows increased or decreased by at least %1$s visits (%2$s%% of %3$s total visits).",
"TitleConsideredInsightsGrowth": "The following rows have a growth of at least %1$s%% compared to %2$s.",
"TitleConsideredMoversAndShakersChanges": "Considered movers only if they grew by more than %1$s%% visits or shrank by less than %2$s%% visits, new entries only if they increased by more than %3$s%% visits (%4$s), and disappeared rows if they shrank by less than %5$s%% visits (%6$s).",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it shrank by fewer (as opposed to more) than a certain number of visits, I don't see how it is a mover… (Changed meaning in the proposal.)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I don't really understand what the text is trying to say. Having it filled with numbers looks like this:
image

IIRC @tsteur build this feature. Maybe he can say more on that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't they need to shrink by more than 84%? As if it only shrank by 60%, then it's not a significant change since the visits also shrank by 60%.

Also maybe it should say and disappeared rows if shrinking by more than %5$s%% (%6$s).?

Generally, movers and shakers would only show rows that changed significantly. Or only shows new or disappeared rows when they have/had at least a certain amount of visits. But we wouldn't show it if a row with little traffic disappeared.

Not sure if any of that helps?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tsteur Is it something like moving more than the average increase, because otherwise all movers and shakers could just happen to be above the threshold when all pages are more or less evenly visited?

Maybe it could be worked out from the numbers, but other than that it just gets harder and harder to understand.

So it is a mover if it is in the 84.1th percentile, and also if it shrank by less than a negative of the total, which is to say it is at the bottom 15,9th percentile for growth?
Or, since the average is -64,1, it has to rank below the Q1 H-spread at -84% and below.
That isn't really what "less than" means though…
Something is missing between "n% ___ visits". Of?
"New" entries are the ones that didn't make the cut-off because they previously were seen by too few people (?), and 5% is either where that puts it, the number of visits 117 amounts to as a percentage-wise gain, or it concerns 117 pages…?
The consideration to go missing is to post a greater decline "less than"-than the bottom 7%(?) Or it went down by 7 pp,
and this concerns either (164) unique visits, or pages.

Also:
Date sequence
"Mar 2022" follows 2335, when it could be
Unique page-views changed from dropped from 6510 in Mar of 2022 to 2335 (when?).
Number behind movers
Whatever (number) is, why isn't it there for movers?
Line shifting
One sentence per line would help
Order of categories
"Disappeared" should maybe come before "New", since the qualification for going missing is the reasoning for coming back from disappearance(?) Don't know if that would help.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it something like moving more than the average increase, because otherwise all movers and shakers could just happen to be above the threshold when all pages are more or less evenly visited?

Exactly. If visits increase say 60%, then it looks at rows that are increasing say more than 80%.

"New" entries are the ones that didn't make the cut-off because they previously were seen by too few people (?), and 5% is either where that puts it, the number of visits 117 amounts to as a percentage-wise gain, or it concerns 117 pages…?

It shows new pages when the row (label) wasn't visible in the previous period and now the row is there. And the row's visits is 5% of the total amount of visits. 117/2335= 5%. If there were more overall visits, then more visits for the row would have been needed than the 117.

Unique page-views changed from dropped from 6510 in Mar of 2022 to 2335 (when?).

That could be shown in the future but would require code changes. IT's basically shown in the date selector. In an ideal world it would say it directly in there.

Number behind movers. Whatever (number) is, why isn't it there for movers?

Sorry not sure what you meant here?

Hope this helps.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tsteur
I changed my proposal to how I currently understand it.
bilde
isn't quite the same string, so there is room for error.

Edit: As I understand it "New" entries can be ones that disappeared previously.
Instead calling it "Included" and "Excluded" makes more sense to me.

@sgiehl sgiehl added the c: i18n For issues around internationalisation and localisation. label Jun 29, 2022
@justinvelluppillai justinvelluppillai added the Needs Review PRs that need a code review label Jun 30, 2022
"TitleRowMoverAndShaker": "This row had a higher impact than the average.",
"TitleConsideredInsightsChanges": "These rows increased or decreased by at least %1$s visits (%2$s%% of %3$s total visits).",
"TitleConsideredInsightsGrowth": "These rows grew at least %1$s%% compared to %2$s.",
"TitleConsideredMoversAndShakersChanges": "Considered movers only with growth of more than %1$s%% visits or falling by more than %2$s%%. As new entries only if increasing by more than %3$s%% (%4$s), and disappeared rows if shrinking by fewer than %5$s%% (%6$s).",
Copy link
Contributor Author

@comradekingu comradekingu Jun 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"TitleConsideredMoversAndShakersChanges": "Considered movers only with growth of more than %1$s%% visits or falling by more than %2$s%%. As new entries only if increasing by more than %3$s%% (%4$s), and disappeared rows if shrinking by fewer than %5$s%% (%6$s).",
"TitleConsideredMoversAndShakersChanges": "Movers are those entries growing more than the %1$s%% percentile, or falling by more than the bottom %2$s%% percentile when ordered by individual growth.\nEverything below 5%% of the total amount of visits (%5$s%% individually, which is %6$s visits within the period) disappears, and appears as new entries only and every time they make it above this threshold (by growing more than %3$s%% individually, which is %4$s visits within the period).",

What to put in "Movers are those ___ growing" pages, rows, entries?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest to use entries (or rows), as it might be any dimension (like pages, browsers, operating systems, countries, ...)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still struggling with this one. I think it might mean what it should, but I'm not fully sure.
@justinvelluppillai would you understand what this should mean:

Movers are those entries growing more than the 84.1% percentile, or falling by more than the bottom -84.1% percentile when ordered by individual growth.
Everything below 5% of the total amount of visits (5% individually, which is 117 visits within the period) disappears, and appears as new entries only and every time they make it above this threshold (by growing more than 7% individually, which is 164 visits within the period).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sgiehl that is not easily understood. I think the existing version is slightly more understandable here.

@github-actions
Copy link
Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Jul 13, 2022
@github-actions
Copy link
Contributor

This PR was last updated more than one month ago, maybe it's time to close it. Please check if there is anything we still can do or close this PR. ping @matomo-org/core-reviewers

@github-actions github-actions bot added the Stale for long The label used by the Close Stale Issues action label Aug 24, 2022
plugins/Insights/lang/en.json Outdated Show resolved Hide resolved
"TitleRowMoverAndShaker": "This row had a higher impact than the average.",
"TitleConsideredInsightsChanges": "These rows increased or decreased by at least %1$s visits (%2$s%% of %3$s total visits).",
"TitleConsideredInsightsGrowth": "These rows grew at least %1$s%% compared to %2$s.",
"TitleConsideredMoversAndShakersChanges": "Considered movers only with growth of more than %1$s%% visits or falling by more than %2$s%%. As new entries only if increasing by more than %3$s%% (%4$s), and disappeared rows if shrinking by fewer than %5$s%% (%6$s).",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still struggling with this one. I think it might mean what it should, but I'm not fully sure.
@justinvelluppillai would you understand what this should mean:

Movers are those entries growing more than the 84.1% percentile, or falling by more than the bottom -84.1% percentile when ordered by individual growth.
Everything below 5% of the total amount of visits (5% individually, which is 117 visits within the period) disappears, and appears as new entries only and every time they make it above this threshold (by growing more than 7% individually, which is 164 visits within the period).

Co-authored-by: Stefan Giehl <stefan@matomo.org>
"TitleRowMoverAndShaker": "This row had a higher impact than the average.",
"TitleConsideredInsightsChanges": "These rows increased or decreased by at least %1$s visits (%2$s%% of %3$s total visits).",
"TitleConsideredInsightsGrowth": "These rows grew at least %1$s%% compared to %2$s.",
"TitleConsideredMoversAndShakersChanges": "Considered movers only with growth of more than %1$s%% visits or falling by more than %2$s%%. As new entries only if increasing by more than %3$s%% (%4$s), and disappeared rows if shrinking by fewer than %5$s%% (%6$s).",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"TitleConsideredMoversAndShakersChanges": "Considered movers only with growth of more than %1$s%% visits or falling by more than %2$s%%. As new entries only if increasing by more than %3$s%% (%4$s), and disappeared rows if shrinking by fewer than %5$s%% (%6$s).",
"TitleConsideredMoversAndShakersChanges": "Movers grow more in a period than %1$s%% of entries did, or shrink more than the %2$s%% falling the most.\nEverything below 5%% of the total amount of visits (%5$s%% individually, which is %6$s visits within the period) disappears, and appears as new entries only and every time they make it above this threshold (by growing more than %3$s%% individually, which is %4$s visits within the period).",

@sgiehl This is shorter, and does away with "percentile".

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me that doesn't sound like the same before.

Movers grow more in a period than %1$s%% of entries did, or shrink more than the %2$s%% falling the most.

The original text said something about growing more than X% visits. Isn't that something else than growing more than X% of entries did?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sgiehl True, but the X% isn't a number of visits, it is a percentage, which is actually a percentile gauge from what I remember.
(Ref. the discussion on the original string above)
To get away from the idea of percentiles, "growth" in this suggestion implies something ultimately ultimately measured in page-visits. (This is clear from reading "visits" later.)
It is however clear that it is in the upper (and lower) echelon from "than then ___ falling the most___.

From my reply in that original discussion I had it figured out at some point.

@sgiehl sgiehl removed Stale The label used by the Close Stale Issues action Stale for long The label used by the Close Stale Issues action labels Dec 1, 2022
@github-actions
Copy link
Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Dec 16, 2022
@github-actions
Copy link
Contributor

This PR was last updated more than one month ago, maybe it's time to close it. Please check if there is anything we still can do or close this PR. ping @matomo-org/core-reviewers

@github-actions github-actions bot added the Stale for long The label used by the Close Stale Issues action label Jan 27, 2023
@sgiehl sgiehl changed the base branch from 4.x-dev to 5.x-dev June 20, 2023 12:35
@sgiehl sgiehl removed Stale The label used by the Close Stale Issues action Stale for long The label used by the Close Stale Issues action labels Jun 20, 2023
@github-actions
Copy link
Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Jun 28, 2023
@michalkleiner
Copy link
Contributor

@sgiehl is this ready for review or still needs further rewording? To be frank I'm unclear on the changes here myself and also not sure if this is still needed or not.

If you think this is still ready for review, please put the 'Needs review' label back, otherwise let's see what other changes are needed or how to progress this.

@michalkleiner michalkleiner removed Needs Review PRs that need a code review Stale The label used by the Close Stale Issues action labels Jul 4, 2023
@github-actions
Copy link
Contributor

If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'.

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Jul 19, 2023
@github-actions
Copy link
Contributor

This PR was last updated more than one month ago, maybe it's time to close it. Please check if there is anything we still can do or close this PR. ping @matomo-org/core-reviewers

@github-actions github-actions bot added the Stale for long The label used by the Close Stale Issues action label Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: i18n For issues around internationalisation and localisation. Stale for long The label used by the Close Stale Issues action Stale The label used by the Close Stale Issues action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants