New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 429 response Code UI #19433
Merged
Merged
Add 429 response Code UI #19433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add template
update error code
add widget rate limit loader
# Conflicts: # plugins/CoreHome/vue/dist/CoreHome.umd.min.js
sgiehl
reviewed
Jun 29, 2022
remove file
update wording
# Conflicts: # plugins/CoreHome/vue/dist/CoreHome.umd.min.js
peterhashair
added
the
not-in-changelog
For issues or pull requests that should not be included in our release changelog on matomo.org.
label
Jul 3, 2022
remove console
peterhashair
commented
Jul 7, 2022
# Conflicts: # plugins/CoreHome/vue/dist/CoreHome.umd.min.js
bx80
suggested changes
Jul 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well. I've left a few comments on how we could improve the messaging.
Co-authored-by: Ben Burgess <88810029+bx80@users.noreply.github.com>
update text and rate limit
remove api docs for now
# Conflicts: # plugins/CoreHome/vue/dist/CoreHome.umd.min.js
bx80
approved these changes
Jul 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Needs Review
PRs that need a code review
not-in-changelog
For issues or pull requests that should not be included in our release changelog on matomo.org.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes : #19233
add 429 notification to javascript and dashboard load.
Review