Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 429 response Code UI #19433

Merged
merged 22 commits into from Jul 20, 2022
Merged

Add 429 response Code UI #19433

merged 22 commits into from Jul 20, 2022

Conversation

peterhashair
Copy link
Contributor

@peterhashair peterhashair commented Jun 29, 2022

Description:

Fixes : #19233

add 429 notification to javascript and dashboard load.

Review

Peter and others added 6 commits June 21, 2022 15:41
add template
update error code
add widget rate limit loader
# Conflicts:
#	plugins/CoreHome/vue/dist/CoreHome.umd.min.js
plugins/API/templates/rateLimit.twig Outdated Show resolved Hide resolved
plugins/Dashboard/javascripts/dashboardWidget.js Outdated Show resolved Hide resolved
lang/en.json Outdated Show resolved Hide resolved
plugins/Morpheus/templates/ajaxMacros.twig Outdated Show resolved Hide resolved
Peter and others added 4 commits June 30, 2022 11:33
remove file
update wording
# Conflicts:
#	plugins/CoreHome/vue/dist/CoreHome.umd.min.js
@peterhashair peterhashair marked this pull request as ready for review July 3, 2022 22:46
@peterhashair peterhashair added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jul 3, 2022
Peter and others added 2 commits July 4, 2022 11:04
@justinvelluppillai justinvelluppillai added the Needs Review PRs that need a code review label Jul 4, 2022
lang/en.json Outdated Show resolved Hide resolved
Peter Zhang and others added 3 commits July 7, 2022 15:34
# Conflicts:
#	plugins/CoreHome/vue/dist/CoreHome.umd.min.js
@peterhashair peterhashair requested a review from bx80 July 12, 2022 23:13
Copy link
Contributor

@bx80 bx80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well. I've left a few comments on how we could improve the messaging.

lang/en.json Outdated Show resolved Hide resolved
plugins/Morpheus/templates/ajaxMacros.twig Outdated Show resolved Hide resolved
plugins/CoreHome/vue/src/AjaxHelper/AjaxHelper.ts Outdated Show resolved Hide resolved
Peter Zhang and others added 7 commits July 13, 2022 16:39
Co-authored-by: Ben Burgess <88810029+bx80@users.noreply.github.com>
update text and rate limit
remove api docs for now
# Conflicts:
#	plugins/CoreHome/vue/dist/CoreHome.umd.min.js
@peterhashair peterhashair merged commit 0eeb042 into 4.x-dev Jul 20, 2022
@peterhashair peterhashair deleted the m19233 branch July 20, 2022 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle 429 response code within UI
4 participants