Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vue] remove use of angularjs from Ecommerce plugin #19432

Merged
merged 14 commits into from Aug 4, 2022
Merged

[Vue] remove use of angularjs from Ecommerce plugin #19432

merged 14 commits into from Aug 4, 2022

Conversation

diosmosis
Copy link
Member

Description:

Changes:

  • Convert conversionOverview.twig contents to Vue component.
  • Add global type definition for SegmentedVisitorLog.show.
  • Remove use of angularjs directives from twig templates.

Review

@diosmosis diosmosis added this to the 5.0.0 milestone Jun 29, 2022
@diosmosis diosmosis marked this pull request as draft June 29, 2022 00:42
@diosmosis diosmosis force-pushed the vue-remove-angularjs-Ecommerce branch from e49cebb to cbb504c Compare June 29, 2022 00:45
@diosmosis diosmosis added the Needs Review PRs that need a code review label Jul 11, 2022
@diosmosis diosmosis marked this pull request as ready for review July 11, 2022 04:56
@github-actions
Copy link
Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Jul 19, 2022
@diosmosis diosmosis added the Do not close PRs with this label won't be marked as stale by the Close Stale Issues action label Jul 19, 2022
@github-actions github-actions bot removed the Stale The label used by the Close Stale Issues action label Jul 20, 2022
@github-actions
Copy link
Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions github-actions bot added Stale The label used by the Close Stale Issues action and removed Stale The label used by the Close Stale Issues action labels Jul 28, 2022
@sgiehl
Copy link
Member

sgiehl commented Aug 4, 2022

Note: some twig files were actually not used anymore, so I've removed them.

@sgiehl sgiehl merged commit e17f393 into 5.x-dev Aug 4, 2022
@sgiehl sgiehl deleted the vue-remove-angularjs-Ecommerce branch August 4, 2022 13:49
@justinvelluppillai justinvelluppillai added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Sep 29, 2022
bx80 pushed a commit that referenced this pull request Nov 25, 2022
@diosmosis @sgiehl @bx80
[Vue] remove use of angularjs from Ecommerce plugin (#19432)
2ec62ed 
* remove use of angularjs from Ecommerce plugin

* built vue files

* Allow composer plugins for dev dependency codesniffer to fix travis builds.

* fix spacing issue

* update expected screenshots

* remove use of unneeded html_attr twig escape filter [ci skip]

* fix component name

* remove obsolete files

* updates expected test files

Co-authored-by: Stefan Giehl <stefan@matomo.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Do not close PRs with this label won't be marked as stale by the Close Stale Issues action Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@diosmosis @sgiehl @justinvelluppillai