Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vue] remove use of angularjs from ExamplePlugin #19431

Merged
merged 9 commits into from Aug 4, 2022

Conversation

diosmosis
Copy link
Member

Description:

Changes:

  • Remove angularjs directives/components from ExamplePlugin.
  • Remove angularjs generation commands from CoreConsole.

Review

@diosmosis diosmosis added this to the 5.0.0 milestone Jun 29, 2022
@diosmosis diosmosis marked this pull request as draft June 29, 2022 00:11
@diosmosis diosmosis added the Needs Review PRs that need a code review label Jul 11, 2022
@diosmosis diosmosis marked this pull request as ready for review July 11, 2022 04:51
@github-actions
Copy link
Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Jul 19, 2022
@diosmosis diosmosis added the Do not close PRs with this label won't be marked as stale by the Close Stale Issues action label Jul 19, 2022
@github-actions github-actions bot removed the Stale The label used by the Close Stale Issues action label Jul 20, 2022
@github-actions
Copy link
Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions github-actions bot added Stale The label used by the Close Stale Issues action and removed Stale The label used by the Close Stale Issues action labels Jul 28, 2022
@sgiehl sgiehl merged commit 5e37e68 into 5.x-dev Aug 4, 2022
@sgiehl sgiehl deleted the vue-remove-angularjs-ExamplePlugin branch August 4, 2022 10:27
@justinvelluppillai justinvelluppillai added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Sep 29, 2022
bx80 pushed a commit that referenced this pull request Nov 25, 2022
* remove use of angularjs from ExamplePlugin and remove angularjs generation commands that depend on it

* Allow composer plugins for dev dependency codesniffer to fix travis builds.

* keep dependent class and rename

* update screenshots

* updates expected test files

Co-authored-by: sgiehl <stefan@matomo.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Do not close PRs with this label won't be marked as stale by the Close Stale Issues action Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants