[Vue] remove use of angularjs from Feedback plugin #19428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o-org/matomo into vue-remove-angularjs-SegmentEditor
…/matomo into vue-remove-angularjs-Feedback
…angularjs-Feedback
|
This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers |
github-actions
bot
added
the
Stale
diosmosis
added
the
Do not close
github-actions
bot
removed
the
Stale
|
This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers |
github-actions
bot
added
Stale
|
This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers |
github-actions
bot
added
Stale
sgiehl
approved these changes
Aug 11, 2022
justinvelluppillai
added
the
not-in-changelog
bx80
pushed a commit
that referenced
this pull request
Nov 25, 2022
* remove use of angularjs from SegmentEditor plugin * remove import added by phpstorm * make sure to export comparison service instance not just class * built vue files * remove angularjs from Feedback plugin * built vue files * fixing some issues * fix initial value for segment definition * treat null, undefined and empty string segment value the same * Update expected screenshots * try to fix timing error in test * correct typing for feedback question input * update screenshots and styling tweak * Allow composer plugins for dev dependency codesniffer to fix travis builds. * update expected screenshot * remove duplicate translation * remove use of html_attr escape * remove use of unneeded html_attr twig escape filter Co-authored-by: sgiehl <stefan@matomo.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR depends on #19391.
Changes:
Review