New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Vue] remove angularjs from Goals plugin #19426
Conversation
…ainer for more convenient embedding of vue-entry use from within other Vue components (primarily for supporting twig Template... events in Vue).
…-org/matomo into vue-remove-angularjs-SitesManager
…o-org/matomo into vue-remove-angularjs-SegmentEditor
…tomo into vue-remove-angularjs-Goals
This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers |
This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers |
This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected. Funnels and MultiChannelConversionAttribution plugin won't work correctly after merge though, as the changes there are required, but not yet merged.
* Remove use of angularjs from SitesManager plugin and add VueEntryContainer for more convenient embedding of vue-entry use from within other Vue components (primarily for supporting twig Template... events in Vue). * remove use of angularjs from SegmentEditor plugin * remove import added by phpstorm * make sure to export comparison service instance not just class * built vue files * forgot to export * built vue files * remove angularjs use from Goals plugin * built vue files * fix ui test issues * fixing some issues * fix initial value for segment definition * treat null, undefined and empty string segment value the same * Update expected screenshots * try to fix timing error in test * remove duplicate translations * remove use of unneeded html_attr escape * remove use of html_attr escape * remove unneeded use of twig html_attr escape Co-authored-by: sgiehl <stefan@matomo.org>
Description:
This PR is based on #19390 and #19391.
Changes:
Review