[Vue] remove angularjs from Installation plugin #19425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ainer for more convenient embedding of vue-entry use from within other Vue components (primarily for supporting twig Template... events in Vue).
…-org/matomo into vue-remove-angularjs-SitesManager
…omo into vue-remove-angularjs-Live
…-org/matomo into vue-remove-angularjs-Installation
…ped slashes so json data gets replaced
…angularjs-Installation
…omo into vue-remove-angularjs-Live
diosmosis
added
Needs Review
github-actions
bot
removed
the
Stale
sgiehl
requested changes
Aug 25, 2022
|
@sgiehl applied fixes |
sgiehl
approved these changes
Aug 26, 2022
justinvelluppillai
added
the
not-in-changelog
bx80
pushed a commit
that referenced
this pull request
Nov 25, 2022
* Remove use of angularjs from SitesManager plugin and add VueEntryContainer for more convenient embedding of vue-entry use from within other Vue components (primarily for supporting twig Template... events in Vue). * remove use of angularjs from Live plugin * built vue files * forgot to export * built vue files * start removing angularjs from Installation * remove angularjs from Installation plugin * allow ContentIntro to be applied conditionally * make Diagnostic results json serializable * built vue files * fix ui test issues * fix spacing * couple fixes * more ui test fixes * make sure installation umd is loaded during installation (as well as translations) * do not use html_attr to escape and in UI tests replace path with escaped slashes so json data gets replaced * update screenshots * Allow composer plugins for dev dependency codesniffer to fix travis builds. * move inline script to vue directive + fix a couple vue warnings * remove inline script in system check widget * use common method to load umd file * remove use of unneeded html_attr escape * remove use of unneeded twig html_attr escape * use html filter explicitly * use href so command+click works * get rid of two vue warnings * use anonymous function for jquery event so this can be used properly * destroy/compile vue components when refreshing live widget * update expected screenshots * remove incorrectly added use * include client side translations in twig template layout for Installation not cached JS Co-authored-by: sgiehl <stefan@matomo.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR is based off of #19418.
Changes:
Review