Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vue] remove use of angularjs from LanguagesManager plugin #19423

Merged
merged 11 commits into from Aug 4, 2022
Merged

[Vue] remove use of angularjs from LanguagesManager plugin #19423

merged 11 commits into from Aug 4, 2022

Conversation

diosmosis
Copy link
Member

Description:

Changes:

  • Create LanguagesDropdown.vue and TranslationSearchPage.vue components to replace twig contents w/ angularjs directive use.
  • Remove angularjs => vue adapters.

Review

@diosmosis diosmosis added this to the 5.0.0 milestone Jun 28, 2022
@diosmosis diosmosis marked this pull request as draft June 28, 2022 20:08
@diosmosis diosmosis added the Needs Review PRs that need a code review label Jul 11, 2022
@diosmosis diosmosis marked this pull request as ready for review July 11, 2022 02:39
@github-actions
Copy link
Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Jul 19, 2022
@diosmosis diosmosis added the Do not close PRs with this label won't be marked as stale by the Close Stale Issues action label Jul 19, 2022
@github-actions github-actions bot removed the Stale The label used by the Close Stale Issues action label Jul 20, 2022
@sgiehl sgiehl force-pushed the vue-remove-angularjs-LanguagesManager branch from e221e52 to 3d8fe40 Compare July 26, 2022 15:29
@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2022

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions github-actions bot added Stale The label used by the Close Stale Issues action and removed Stale The label used by the Close Stale Issues action labels Aug 3, 2022
sgiehl
sgiehl approved these changes Aug 4, 2022
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@diosmosis Seems vue was actually dropping the value for nonce. Not sure why that is the case. Maybe nonce has some sort of special handling in vue 🤷
Renaming the variable to form-nonce fixed the problem though...

@sgiehl sgiehl merged commit 2c6134e into 5.x-dev Aug 4, 2022
@sgiehl sgiehl deleted the vue-remove-angularjs-LanguagesManager branch August 4, 2022 12:41
@diosmosis
Copy link
Member Author

Seems vue was actually dropping the value for nonce

Yeah, noticed Vue does this, wasn't able to figure out why either. Might be related to https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/nonce

@justinvelluppillai justinvelluppillai added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Sep 29, 2022
bx80 pushed a commit that referenced this pull request Nov 25, 2022
@diosmosis @sgiehl @bx80
[Vue] remove use of angularjs from LanguagesManager plugin (#19423)
1803ffa 
* remove use of angularjs from LanguagesManager plugin

* add translations

* built vue files

* get languages dropdown to work

* remove use of unneeded html_attr escape

* renamend variable

Co-authored-by: sgiehl <stefan@matomo.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Do not close PRs with this label won't be marked as stale by the Close Stale Issues action Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@diosmosis @sgiehl @justinvelluppillai