@diosmosis opened this Pull Request on June 28th 2022 Member

Description:

Changes:

  • Create LanguagesDropdown.vue and TranslationSearchPage.vue components to replace twig contents w/ angularjs directive use.
  • Remove angularjs => vue adapters.

Review

@github-actions[bot] commented on July 19th 2022 Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions[bot] commented on August 3rd 2022 Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@diosmosis commented on August 5th 2022 Member

Seems vue was actually dropping the value for nonce

Yeah, noticed Vue does this, wasn't able to figure out why either. Might be related to https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/nonce

This Pull Request was closed on August 4th 2022
Powered by GitHub Issue Mirror