Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vue] Make sure active reporting category can be toggled off. #19422

Merged
merged 1 commit into from Jun 29, 2022
Merged

[Vue] Make sure active reporting category can be toggled off. #19422

merged 1 commit into from Jun 29, 2022

Conversation

diosmosis
Copy link
Member

Description:

Fixes #19419

Allow activeCategoryId property to have three possible states: undefined (defaults to query parameter value), null (not set, no expanded), value (active and expanded).

Review

@diosmosis diosmosis added this to the 4.12.0 milestone Jun 28, 2022
@diosmosis diosmosis added the Needs Review PRs that need a code review label Jun 28, 2022
@sgiehl sgiehl modified the milestones: 4.12.0, 4.11.0 Jun 29, 2022
@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should. and removed Needs Review PRs that need a code review labels Jun 29, 2022
@sgiehl sgiehl merged commit 39d9272 into next_release Jun 29, 2022
@sgiehl sgiehl deleted the vue-19419-reporting-menu-category-untoggle branch June 29, 2022 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

@peterhashair peterhashair Awaiting requested review from peterhashair

Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
4.11.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@diosmosis @sgiehl