Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement url parameter to ignore referrer #19420

Merged
merged 3 commits into from Jul 8, 2022
Merged

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jun 28, 2022

Description:

The PR implements ignoring referrers based on url parameters. If the tracked url contains the parameter ignore_referrer=1or ignore_referer=1, the referrer will be ignored. In addition this parameter will be removed from the tracked url.

This behavior is implemented in JavaScript tracker but also on PHP side.

Once this was merged, we need to update/create an FAQ.

refs #18612

Review

Copy link
Contributor

@bx80 bx80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, I did some functional testing with and without the ignore_referrer parameter, looked through the code and confirmed the JavaScript tests pass 👍

@sgiehl sgiehl removed the Needs Review PRs that need a code review label Jul 8, 2022
@sgiehl sgiehl merged commit 89a44ab into 4.x-dev Jul 8, 2022
@sgiehl sgiehl deleted the ignorereferrerparams branch July 8, 2022 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants