Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes reporting menu category doesn't close when clicking on it #19419

Closed
tsteur opened this issue Jun 28, 2022 · 1 comment
Closed

Fixes reporting menu category doesn't close when clicking on it #19419

tsteur opened this issue Jun 28, 2022 · 1 comment
Assignees
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Milestone

Comments

@tsteur
Copy link
Member

tsteur commented Jun 28, 2022

I believe this might be a regression.

When I click on eg Behaviour then it doesn't close the menu

image

This causes me having to scroll down to get to the other menus and can't switch easily anymore. The admin reporting menu still works.

@tsteur tsteur added the Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. label Jun 28, 2022
@sgiehl
Copy link
Member

sgiehl commented Jun 28, 2022

Yes. That seems to be a regression from the vue migration. It seems currently always one menu item is visible, which is either the category currently selected or another category the user toggled through click. It's not possible to hide all categorie menus anymore.

ping @diosmosis could you have a look at that?

@sgiehl sgiehl added Regression Indicates a feature used to work in a certain way but it no longer does even though it should. and removed Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. labels Jun 28, 2022
@sgiehl sgiehl added this to the 4.12.0 milestone Jun 28, 2022
@sgiehl sgiehl modified the milestones: 4.12.0, 4.11.0 Jul 5, 2022
@sgiehl sgiehl closed this as completed Jul 5, 2022
@justinvelluppillai justinvelluppillai changed the title Reporting menu category doesn't close when clicking on it Fixes reporting menu category doesn't close when clicking on it Sep 29, 2022
@justinvelluppillai justinvelluppillai added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Development

No branches or pull requests

4 participants