@diosmosis opened this Pull Request on June 28th 2022 Member

Description:

This PR is based off of #19390.

Changes:

  • Add Passthrough component to CoreHome for easy way to conditionally surround elements w/ a component (see LivePage.vue for use).
  • Move twig contents in Live that use angularjs directives to new Vue components.
  • Replace uses of $rootScope.$emit w/ Matomo.postEvent.

Review

@github-actions[bot] commented on July 19th 2022 Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions[bot] commented on July 28th 2022 Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@diosmosis commented on August 5th 2022 Member

Seems like there's one Live test failure here, where the icons are padded differently, however this doesn't seem Vue related as the rendering is done in twig and vue-directive doesn't actually invoke Vue.

@diosmosis commented on August 16th 2022 Member

@sgiehl applied a fix for what I think you're referring to

@sgiehl commented on August 16th 2022 Member

@diosmosis I was referrering to the profile links in this widget, which still don't work:

image

@diosmosis commented on August 16th 2022 Member

@sgiehl I see, should be fixed

@sgiehl commented on August 16th 2022 Member

@diosmosis found another issue. It seems that the real time widget looses its head on the first refresh. Guess that is caused by this code:
https://github.com/matomo-org/matomo/blob/d868c5c76d707e5e41666421ed27418c397806ef/plugins/Live/vue/src/LiveWidget/LiveWidgetRefresh.ts#L27-L38
Guess the vue component would need to be initialized after the content was replaced...

@diosmosis commented on August 16th 2022 Member

@sgiehl fixed

@sgiehl commented on August 17th 2022 Member

@diosmosis this seems to work on the real time page now. but not when displayed as a widget. In the widget the header seems not to be replaced at all.

@diosmosis commented on August 17th 2022 Member

@sgiehl interesting, I only tested in the widget on the dashboard. Tested again on both sites and it works for me. Could it be a caching issue on your end? Can you test again?

Powered by GitHub Issue Mirror