New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Vue] remove angularjs from Login plugin #19417
Conversation
…ularjs adapters and modify less styles that use directive attribute names
…ew vue components and add vue component for Logins formErrors.twig template
de156d6
to
0ee6d08
Compare
…o-org/matomo into vue-remove-angularjs-users-manager
…ularjs-TwoFactorAuth
…o-org/matomo into vue-remove-angularjs-TwoFactorAuth
…ularjs-TwoFactorAuth
…ularjs-TwoFactorAuth
…ularjs-TwoFactorAuth
This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers |
This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers |
This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers |
This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers |
e805900
to
2e87d7d
Compare
2e87d7d
to
4c55c69
Compare
* convert twig templates using directives to vue components, remove angularjs adapters and modify less styles that use directive attribute names * built vue files * move use of angularjs directives in TwoFactorAuth twig templates to new vue components and add vue component for Logins formErrors.twig template * built vue files * remove use of angularjs from Login plugin * built vue files * add missing translations * fixing UI tests * more UI test fixex * remove reference to nonexistant JS file * updated expected screenshots * fixing ui test failures * update expected screenshots * fixing ui test failures * fix select on focus use * fix placement of computed property * fixing ui test issues * prevent random failure * make sure Login plugin UMD is always loaded * formErrors is an object if supplied * compile vue entry components in reset API response and modify check for success * rebuild login * update expected screenshot * remove unneeded use of html_attr escape * remove use of unneeded twig escape filter, html_attr + remove duplicate translations * fix brute force log Co-authored-by: sgiehl <stefan@matomo.org>
Description:
This PR is based off of #19382.
Changes:
Review