Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vue] remove angularjs from marketplace #19416

Merged
merged 25 commits into from Aug 16, 2022
Merged

[Vue] remove angularjs from marketplace #19416

merged 25 commits into from Aug 16, 2022

Conversation

diosmosis
Copy link
Member

Description:

Changes:

  • Convert twig templates/macros in CorePluginsAdmin that use angularjs directives to Vue.
  • Move PluginName.ts vue directive to CorePluginsAdmin to solve circular dependency issue.
  • Convert twig templates in Marketplace to Vue components.
  • Remove angularjs => vue adapters.

Review

@diosmosis diosmosis added this to the 5.0.0 milestone Jun 27, 2022
@diosmosis diosmosis marked this pull request as draft June 27, 2022 21:22
@diosmosis
built vue files
5688f34
@diosmosis
Merge branch '5.x-dev' into vue-remove-angularjs-Marketplace
59658df
@diosmosis
Merge branch 'vue-remove-angularjs-Marketplace' of github.com:matomo-…
ad3a495 
…org/matomo into vue-remove-angularjs-Marketplace
@diosmosis
fixing UI tests locally
2385b93
@diosmosis
add missing translations
36fbb0c
@diosmosis
couple small UI test fixes
bb57058
@diosmosis
move UploadPluginDialog to CorePluginsAdmin so it will be available w…
1205d9e 
…hen internet access is not available and the Marketplace plugin is deactivated
@diosmosis
revert last tweak
210be97
@diosmosis
styling tweak
1d78102
@diosmosis
Allow composer plugins for dev dependency codesniffer to fix travis b…
8183a80 
…uilds.
@diosmosis
Merge branch 'composer-allow-plugins-phpcodesniffer' into vue-remove-…
ebec830 
…angularjs-Marketplace
@diosmosis
styling tweaks
92e4bed
@diosmosis
comma spacing tweak
6c9811e
@diosmosis
update screenshots + fix v-show condition
bc2ff51
@diosmosis
remove duplicate tokens
a0b39e7
@diosmosis
Merge branch '5.x-dev' into vue-remove-angularjs-Marketplace
06698dc
@diosmosis
remove use of unneeded twig escape filter html_attr
bd7aad1
@diosmosis diosmosis added the Needs Review PRs that need a code review label Jul 11, 2022
@diosmosis diosmosis marked this pull request as ready for review July 11, 2022 02:23
@github-actions
Copy link
Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Jul 19, 2022
@diosmosis diosmosis added the Do not close PRs with this label won't be marked as stale by the Close Stale Issues action label Jul 19, 2022
@github-actions github-actions bot removed the Stale The label used by the Close Stale Issues action label Jul 20, 2022
@github-actions
Copy link
Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions github-actions bot added Stale The label used by the Close Stale Issues action and removed Stale The label used by the Close Stale Issues action labels Jul 28, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2022

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions github-actions bot added Stale The label used by the Close Stale Issues action and removed Stale The label used by the Close Stale Issues action labels Aug 5, 2022
sgiehl
sgiehl requested changes Aug 10, 2022
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not yet finished with the review, but already want to leave the stuff I've found. Might add more comments if anything else doesn't work.

Edit: Review finished. haven't found anything else.

plugins/Marketplace/templates/uploadPluginDialog.twig Outdated Show resolved Hide resolved
plugins/CorePluginsAdmin/vue/src/PluginsIntro/PluginsIntro.vue Outdated Show resolved Hide resolved
plugins/CorePluginsAdmin/vue/src/PluginsTable/PluginsTableWithUpdates.vue Outdated Show resolved Hide resolved
plugins/CorePluginsAdmin/vue/src/PluginsTable/PluginsTableWithUpdates.vue Outdated Show resolved Hide resolved
plugins/CorePluginsAdmin/vue/src/PluginsTable/PluginsTable.vue Outdated Show resolved Hide resolved
plugins/Marketplace/vue/src/GetNewPluginsAdmin/GetNewPluginsAdmin.vue Outdated Show resolved Hide resolved
@sgiehl sgiehl removed the Needs Review PRs that need a code review label Aug 11, 2022
@diosmosis
Copy link
Member Author

@sgiehl applied more fixes

@sgiehl sgiehl force-pushed the vue-remove-angularjs-Marketplace branch from 1341918 to 19e089e Compare August 16, 2022 09:52
sgiehl
sgiehl approved these changes Aug 16, 2022
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couldn't find any further issues...

@sgiehl sgiehl merged commit 309332f into 5.x-dev Aug 16, 2022
@sgiehl sgiehl deleted the vue-remove-angularjs-Marketplace branch August 16, 2022 10:03
@justinvelluppillai justinvelluppillai added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Sep 29, 2022
bx80 pushed a commit that referenced this pull request Nov 25, 2022
@diosmosis @sgiehl @bx80
[Vue] remove angularjs from marketplace (#19416)
6d3d601 
* start removing angularjs from Marketplace plugin

* finish removing angularjs from marketplace and some twig templates in CorePluginsAdmin

* built vue files

* fixing UI tests locally

* add missing translations

* couple small UI test fixes

* move UploadPluginDialog to CorePluginsAdmin so it will be available when internet access is not available and the Marketplace plugin is deactivated

* revert last tweak

* styling tweak

* Allow composer plugins for dev dependency codesniffer to fix travis builds.

* styling tweaks

* comma spacing tweak

* update screenshots + fix v-show condition

* remove duplicate tokens

* remove use of unneeded twig escape filter html_attr

* apply review feedback + fix some other issues found while testing quickly

* updates expected test files

Co-authored-by: sgiehl <stefan@matomo.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Do not close PRs with this label won't be marked as stale by the Close Stale Issues action not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@diosmosis @sgiehl @justinvelluppillai