Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Indonesia & Malaysia are located on Oceania map #19415

Merged
merged 1 commit into from Jun 28, 2022
Merged

Fix: Indonesia & Malaysia are located on Oceania map #19415

merged 1 commit into from Jun 28, 2022

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jun 27, 2022

Description:

refs #19411

Review

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Jun 27, 2022
@sgiehl sgiehl added this to the 4.12.0 milestone Jun 27, 2022
@sgiehl sgiehl mentioned this pull request Jun 27, 2022
Closed
peterhashair
peterhashair reviewed Jun 27, 2022
View reviewed changes
Copy link
Contributor

@peterhashair peterhashair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when you click Indonesia & Malaysia, it relocated to Oceania, but the focus is on Australia, When you click Turkey, it relocated to China.

@sgiehl
Copy link
Member Author

sgiehl commented Jun 28, 2022

@peterhashair That is how our map is currently working. When you click on any country on the world map, a map of the continent where that country is on will be shown. From there you can step into each country. The fix here simply displays another continent map for Indonesia & Malaysia, as they are not visible on the Asia one. Turkey should be visible on that one.

@peterhashair
Copy link
Contributor

@sgiehl right that makes sense.

@sgiehl sgiehl merged commit fbb8913 into 4.x-dev Jun 28, 2022
@sgiehl sgiehl deleted the mapfix branch June 28, 2022 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterhashair peterhashair peterhashair approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.12.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sgiehl @peterhashair