Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ReportsProvider.php #19414

Merged
merged 1 commit into from Jun 27, 2022
Merged

Update ReportsProvider.php #19414

merged 1 commit into from Jun 27, 2022

Conversation

Prinzhorn
Copy link
Contributor

Copying this from the docs caused

Unmatched '}'

and fixing it caused

Call to undefined method Piwik\Plugins\API\Reports\Get::getCategory()

and logging getCategoryId() shows that Actions is not correct either. But using General_Actions doesn't remove any menus either, even though unset is called.

I feel like the first person using these APIs (refs #19389)

Review

@Prinzhorn
Update ReportsProvider.php
2ed4331 
Copying this from the docs caused

> Unmatched '}'

and fixing it caused

> Call to undefined method Piwik\Plugins\API\Reports\Get::getCategory()

and logging `getCategoryId()` shows that `Actions` is not correct either. But using `General_Actions` doesn't remove any menus either, even though `unset` is called.

I feel like the first person using these APIs (refs matomo-org#19389)
@Prinzhorn Prinzhorn mentioned this pull request Jun 27, 2022
Open
@Prinzhorn
Copy link
Contributor Author

Prinzhorn commented Jun 27, 2022 •
edited

Never mind, it actually removes some things. E.g. using Referrers_Referrers will still leave one menu/widget intact for some reason?
Selection_1231

None of the reports in filterReports have category Marketplace_Marketplace. So this might be a timing issue? Are these added after filterReports was called?

@sgiehl sgiehl merged commit 4753deb into matomo-org:4.x-dev Jun 27, 2022
@sgiehl sgiehl added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jun 27, 2022
@sgiehl sgiehl added this to the 4.12.0 milestone Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.12.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Prinzhorn @sgiehl