Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vue] apply #19375 to next_release #19412

Merged
merged 1 commit into from Jun 27, 2022
Merged

[Vue] apply #19375 to next_release #19412

merged 1 commit into from Jun 27, 2022

Conversation

diosmosis
Copy link
Member

Description:

Noticed this issue far more when converting the Morpheus, demo.twig page. Think this change should go into the next release.

Review

@diosmosis
instead of resetting modelValue before sending update:modelValue, res…
2d651ce 
…et after if modelValue has not changed so cursor change will only happen if change is disallowed
@diosmosis diosmosis added Needs Review PRs that need a code review Regression Indicates a feature used to work in a certain way but it no longer does even though it should. labels Jun 26, 2022
@diosmosis diosmosis added this to the 4.12.0 milestone Jun 26, 2022
@sgiehl sgiehl merged commit 7cc40a8 into next_release Jun 27, 2022
@sgiehl sgiehl deleted the next-release-vue-19303-different-order-model-reset branch June 27, 2022 10:17
@justinvelluppillai justinvelluppillai added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterhashair peterhashair peterhashair approved these changes

@sgiehl sgiehl Awaiting requested review from sgiehl

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
4.12.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@diosmosis @peterhashair @justinvelluppillai @sgiehl