[Vue] remove angularjs use from MobileMessaging #19410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…angularjs-MobileMessaging
…omo-org/matomo into vue-remove-angularjs-MobileMessaging
…omo-org/matomo into vue-remove-angularjs-MobileMessaging
|
This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers |
github-actions
bot
added
the
Stale
diosmosis
added
the
Do not close
github-actions
bot
removed
the
Stale
|
This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers |
github-actions
bot
added
Stale
sgiehl
force-pushed
the
vue-remove-angularjs-MobileMessaging
branch
from
cb5dc01
to
f19c4ed
Compare
sgiehl
approved these changes
Aug 4, 2022
There was a problem hiding this comment.
Seems to work as expected. But will require matomo-org/plugin-CustomAlerts#121 to merged first
justinvelluppillai
added
the
not-in-changelog
bx80
pushed a commit
that referenced
this pull request
Nov 25, 2022
* remove use of angularjs from ScheduledReports plugin * remove extra space * built vue files * remove angularjs use from MobileMessaging, creating new AdminPage component for index.twig * built vue files * fix report binding * get propagation of property to child vue-entry components to work, if strangely * try removing prefix/suffix entirely from vue entry properties * revert back to suffixing an underscore * built vue files * add missing vue-entry property + add missing translations * update CustomAlerts submodule * remove duplicate translations * remove duplicate translation * remove use of unneeded html_attr * remove unneeded use of html_attr filter * update submodule Co-authored-by: sgiehl <stefan@matomo.org>
bx80
pushed a commit
that referenced
this pull request
Nov 25, 2022
* remove use of angularjs from ScheduledReports plugin * remove extra space * built vue files * remove angularjs use from MobileMessaging, creating new AdminPage component for index.twig * built vue files * fix report binding * get propagation of property to child vue-entry components to work, if strangely * try removing prefix/suffix entirely from vue entry properties * revert back to suffixing an underscore * built vue files * add missing vue-entry property + add missing translations * update CustomAlerts submodule * remove duplicate translations * remove duplicate translation * remove use of unneeded html_attr * remove unneeded use of html_attr filter * update submodule Co-authored-by: sgiehl <stefan@matomo.org>
bx80
pushed a commit
that referenced
this pull request
Nov 25, 2022
* remove use of angularjs from ScheduledReports plugin * remove extra space * built vue files * remove angularjs use from MobileMessaging, creating new AdminPage component for index.twig * built vue files * fix report binding * get propagation of property to child vue-entry components to work, if strangely * try removing prefix/suffix entirely from vue entry properties * revert back to suffixing an underscore * built vue files * add missing vue-entry property + add missing translations * update CustomAlerts submodule * remove duplicate translations * remove duplicate translation * remove use of unneeded html_attr * remove unneeded use of html_attr filter * update submodule Co-authored-by: sgiehl <stefan@matomo.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR is based off of #19402.
Changes:
Review