New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Vue] remove angularjs from the Morpheus plugin #19409
Conversation
…o-org/matomo into vue-remove-angularjs-SegmentEditor
…/matomo into vue-remove-angularjs-Morpheus
This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers |
This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers |
This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers |
77819d4
to
2a672ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merged in the latest changes. Left two comments. Once they are clarified, this should be good to merge. Might be possible some screenshots needs another update...
{% if rate is defined and rate and rate is true %}piwik-enriched-headline="{{ title|e('html_attr') }}" | ||
{% elseif rate is defined and rate and rate %}piwik-enriched-headline="{{ rate|e('html_attr') }}"{% endif %} | ||
{% if rate is defined and rate and rate is true %}vue-entry="CoreHome.EnrichedHeadline" | ||
{% elseif rate is defined and rate and rate %}vue-entry="CoreHome.EnrichedHeadline"{% endif %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this change make sense? Before it was either assigned title
or rate
to the headline. While I'm not sure if the old angular component was handling that at all, I don't think the new vue component does, or am I wrong?
Also the second condition has a duplicate and rate
, which is useless.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The old directive doesn't handle a piwikEnrichedHeadline attribute value so I don't think this code actually did anything before. So my reasoning is it should be fine to remove it.
rules: { | ||
'max-len': 'off', | ||
}, | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this file still needed? Doesn't look like there are any lines that are too long.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's gone now so I'm guessing it's not.
@sgiehl applied review feedback |
* remove use of angularjs from SegmentEditor plugin * remove import added by phpstorm * convert part of demo.twig * make sure to export comparison service instance not just class * built vue files * finish converting demo.twig * finish converting demo.twig * remove some remaining angularjs references * built vue files * fixing some issues * fix initial value for segment definition * treat null, undefined and empty string segment value the same * Update expected screenshots * try to fix timing error in test * update screenshots * remove use of html_attr escape * remove unneeded hmtl_attr filter use * apply review feedback * updates expected test files Co-authored-by: sgiehl <stefan@matomo.org>
Description:
This PR is based off of #19391.
Changes:
Review