Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vue] remove angularjs from Overlay plugin #19406

Merged
merged 8 commits into from Jul 27, 2022
Merged

Conversation

diosmosis
Copy link
Member

Description:

Changes:

  • Remove use of angularjs from Piwik_Overlay.js, replacing angularjs services w/ Vue stores.

Review

@diosmosis diosmosis added this to the 5.0.0 milestone Jun 25, 2022
@diosmosis diosmosis marked this pull request as draft June 25, 2022 00:00
@diosmosis diosmosis added the Needs Review PRs that need a code review label Jul 11, 2022
@diosmosis diosmosis marked this pull request as ready for review July 11, 2022 02:11
@github-actions
Copy link
Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Jul 18, 2022
@diosmosis diosmosis added the Do not close PRs with this label won't be marked as stale by the Close Stale Issues action label Jul 18, 2022
@github-actions github-actions bot removed the Stale The label used by the Close Stale Issues action label Jul 19, 2022
@sgiehl sgiehl merged commit 696721a into 5.x-dev Jul 27, 2022
@sgiehl sgiehl deleted the vue-remove-angularjs-Overlay branch July 27, 2022 07:21
@justinvelluppillai justinvelluppillai added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Sep 29, 2022
bx80 pushed a commit that referenced this pull request Nov 25, 2022
* remove use of angularjs from Piwik_Overlay.js

* remove import added by phpstorm

* remove leading hash characters from hash value

* do not attempt to print if puppeteer context is destroyed

* do not abort ajax requests when loading the sidebar

Co-authored-by: sgiehl <stefan@matomo.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Do not close PRs with this label won't be marked as stale by the Close Stale Issues action Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants