New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Vue] remove angularjs from PrivacyManager plugin #19404
Conversation
…ainer for more convenient embedding of vue-entry use from within other Vue components (primarily for supporting twig Template... events in Vue).
…-org/matomo into vue-remove-angularjs-SitesManager
…mo-org/matomo into vue-remove-angularjs-PrivacyManager
…larjs-PrivacyManager
This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers |
This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers |
This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merged this one with the latest changes. Everything (still) seems to work as expected.
* Remove use of angularjs from SitesManager plugin and add VueEntryContainer for more convenient embedding of vue-entry use from within other Vue components (primarily for supporting twig Template... events in Vue). * rebuild * built vue files * forgot to export * built vue files * fix ui test issues * add missing translations * fix issues from UI tests * update screenshot * remove duplicate translations * remove use of unneeded html_attr escape * remove use of html_attr twig escape * sort and deduplicate translation keys * remove some confirms left over from merge Co-authored-by: sgiehl <stefan@matomo.org>
Description:
This PR is based off of #19390.
Changes:
Review