Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vue] remove use of angularjs from ScheduledReports plugin #19402

Merged
merged 13 commits into from Aug 4, 2022
Merged

[Vue] remove use of angularjs from ScheduledReports plugin #19402

merged 13 commits into from Aug 4, 2022

Conversation

diosmosis
Copy link
Member

@diosmosis diosmosis commented Jun 24, 2022 •
edited

Description:

Changes:

  • Remove use of angularjs directives in twig.
  • No longer support use of angularjs in Template.reportParametersScheduledReports event content.
  • No longer support the use of inline scripts in Template.reportParametersScheduledReports event content.
  • In compileVueEntryComponents() save vue app instance in jquery data. This allows users of the function to be able to modify any extra property values passed in initially. (Note: this approach is used to pass the report to vue-entry children in the twig event used to extend scheduled reports' edit form, but shouldn't be used for new code. Vue components should be passed and obtained via useExternalPluginComponent, and twig events should not be used.)

Review

@diosmosis diosmosis added this to the 5.0.0 milestone Jun 24, 2022
@diosmosis diosmosis marked this pull request as draft June 24, 2022 18:36
@diosmosis diosmosis force-pushed the vue-remove-angularjs-ScheduledReports branch from 3deeb75 to 1c89eb1 Compare June 24, 2022 19:02
@diosmosis diosmosis mentioned this pull request Jul 4, 2022
Merged
11 tasks
@diosmosis diosmosis added the Needs Review PRs that need a code review label Jul 11, 2022
@diosmosis diosmosis marked this pull request as ready for review July 11, 2022 02:03
@github-actions
Copy link
Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Jul 18, 2022
@diosmosis diosmosis added the Do not close PRs with this label won't be marked as stale by the Close Stale Issues action label Jul 18, 2022
@github-actions github-actions bot removed the Stale The label used by the Close Stale Issues action label Jul 19, 2022
@github-actions
Copy link
Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions github-actions bot added Stale The label used by the Close Stale Issues action and removed Stale The label used by the Close Stale Issues action labels Jul 27, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2022

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions github-actions bot added Stale The label used by the Close Stale Issues action and removed Stale The label used by the Close Stale Issues action labels Aug 4, 2022
@sgiehl sgiehl merged commit 834cc6f into 5.x-dev Aug 4, 2022
@sgiehl sgiehl deleted the vue-remove-angularjs-ScheduledReports branch August 4, 2022 08:31
@justinvelluppillai justinvelluppillai added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Sep 29, 2022
bx80 pushed a commit that referenced this pull request Nov 25, 2022
@diosmosis @sgiehl @bx80
[Vue] remove use of angularjs from ScheduledReports plugin (#19402)
51a21cf 
* remove use of angularjs from ScheduledReports plugin

* remove extra space

* built vue files

* fix report binding

* get propagation of property to child vue-entry components to work, if strangely

* try removing prefix/suffix entirely from vue entry properties

* revert back to suffixing an underscore

* remove duplicate translation

* remove use of unneeded html_attr

* fix emailMe param

Co-authored-by: sgiehl <stefan@matomo.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Do not close PRs with this label won't be marked as stale by the Close Stale Issues action Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@diosmosis @sgiehl @justinvelluppillai