@diosmosis opened this Pull Request on June 24th 2022 Member

Description:

Changes:

  • Remove use of angularjs directives in twig.
  • No longer support use of angularjs in Template.reportParametersScheduledReports event content.
  • No longer support the use of inline scripts in Template.reportParametersScheduledReports event content.
  • In compileVueEntryComponents() save vue app instance in jquery data. This allows users of the function to be able to modify any extra property values passed in initially. (Note: this approach is used to pass the report to vue-entry children in the twig event used to extend scheduled reports' edit form, but shouldn't be used for new code. Vue components should be passed and obtained via useExternalPluginComponent, and twig events should not be used.)

Review

@github-actions[bot] commented on July 18th 2022 Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions[bot] commented on July 27th 2022 Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions[bot] commented on August 4th 2022 Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

This Pull Request was closed on August 4th 2022
Powered by GitHub Issue Mirror