Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure download urls are decoded in visits log #19400

Merged
merged 1 commit into from Jun 28, 2022
Merged

Ensure download urls are decoded in visits log #19400

merged 1 commit into from Jun 28, 2022

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jun 24, 2022

Description:

fixes #15924

Review

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Jun 24, 2022
@sgiehl sgiehl added this to the 4.12.0 milestone Jun 24, 2022
@sgiehl sgiehl changed the title Ensure downoad urls are decoded in visits log Ensure download urls are decoded in visits log Jun 24, 2022
@sgiehl sgiehl requested a review from bx80 June 27, 2022 13:29
bx80
bx80 approved these changes Jun 28, 2022
View reviewed changes
Copy link
Contributor

@bx80 bx80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested by recreating the issue with a _paq.push link track for a download with an ampersand in the url. Without this change the visitor log shows the ampersand encoded, after the change the download link is shown correctly 👍

@sgiehl sgiehl merged commit ed6652b into 4.x-dev Jun 28, 2022
@sgiehl sgiehl deleted the m15924 branch June 28, 2022 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bx80 bx80 bx80 approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.12.0
Development

Successfully merging this pull request may close these issues.

Ensure download urls are encoded correctly in visits log
2 participants
@sgiehl @bx80