@robocoder opened this Issue on January 4th 2011 Contributor

Check for non-empty settings that likely conflict. Examples:

output_handler = ob_gzhandler


auto_append_file = gzip_end.php
auto_prepend_file = gzip_start.php

In these cases, we should set: disable_merged_assets = 1 or add a new setting to disable only the compression aspect (given that serveStaticFile is also used by the piwik.* proxy).

@mattab commented on January 4th 2011 Member

we should only disable compression if possible, rather than disabling merged assets.

@mattab commented on January 5th 2011 Member

Could this be detected by a simple ini_get ?

@robocoder commented on January 5th 2011 Contributor

Yes, if any of the above settings are non-empty, disable compression. We can do this at runtime.

auto_append_file/auto_prepend_file - those are user-defined files (for the example, I used a user's config)

output_handler could be ob_gzhandler, ob_deflatehandler, ob_inflatehandler, ob_iconv_handler, ob_tidyhandler, mb_output_handler, ...

@robocoder commented on January 5th 2011 Contributor

(In [3630]) fixes #1940 - runtime detection for possible conflict

This Issue was closed on January 5th 2011
Powered by GitHub Issue Mirror