Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve date range when switching between periods in evolution graphs #19395

Merged
merged 1 commit into from Jul 11, 2022
Merged

Preserve date range when switching between periods in evolution graphs #19395

merged 1 commit into from Jul 11, 2022

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jun 23, 2022

Description:

fixes #19393

Review

@sgiehl sgiehl added the Needs Review PRs that need a code review label Jun 23, 2022
@sgiehl sgiehl added this to the 4.12.0 milestone Jun 23, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2022

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Jul 1, 2022
bx80
bx80 approved these changes Jul 11, 2022
View reviewed changes
Copy link
Contributor

@bx80 bx80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recreated the issue then confirmed that this change fixes it. Tried a number of period ranges, date ranges and lastN values all of which worked correctly when switching back to the original 'day' period. 👍

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. and removed Needs Review PRs that need a code review Stale The label used by the Close Stale Issues action labels Jul 11, 2022
@sgiehl sgiehl merged commit 87e5fb1 into 4.x-dev Jul 11, 2022
@sgiehl sgiehl deleted the m19393 branch July 11, 2022 10:13
@sgiehl sgiehl mentioned this pull request Nov 8, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bx80 bx80 bx80 approved these changes

@justinvelluppillai justinvelluppillai Awaiting requested review from justinvelluppillai

Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.12.0
Development

Successfully merging this pull request may close these issues.

Fix date range handling to prevent evolution graph display being confused when changing the period
2 participants
@sgiehl @bx80