@diosmosis opened this Pull Request on June 23rd 2022 Member

Description:

Changes:

  • Add piwikHelper.isReportingPage() and deprecate piwikHelper.isAngularRenderingThePage().
  • In Segmentation.js remove references to AngularJS and directly use Vue stores/components/etc.
  • Remove use of angularjs directives in twig templates.
  • Remove angularjs => vue adapters.

Review

@github-actions[bot] commented on July 18th 2022 Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions[bot] commented on July 27th 2022 Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@diosmosis commented on August 4th 2022 Member

@sgiehl fixed the issue you mentioned. Did some more manual testing, but not a comprehensive test, and couldn't find anything else, but the Segmentation.js code can be confusing so it's very possible I missed something.

This Pull Request was closed on August 8th 2022
Powered by GitHub Issue Mirror