Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vue] remove use of angularjs from SegmentEditor plugin #19391

Merged
merged 22 commits into from Aug 8, 2022
Merged

[Vue] remove use of angularjs from SegmentEditor plugin #19391

merged 22 commits into from Aug 8, 2022

Conversation

diosmosis
Copy link
Member

@diosmosis diosmosis commented Jun 23, 2022 •
edited

Description:

Changes:

  • Add piwikHelper.isReportingPage() and deprecate piwikHelper.isAngularRenderingThePage().
  • In Segmentation.js remove references to AngularJS and directly use Vue stores/components/etc.
  • Remove use of angularjs directives in twig templates.
  • Remove angularjs => vue adapters.

Review

@diosmosis diosmosis added this to the 5.0.0 milestone Jun 23, 2022
@diosmosis diosmosis marked this pull request as draft June 23, 2022 02:15
@diosmosis diosmosis force-pushed the vue-remove-angularjs-SegmentEditor branch from b4a24a8 to ed04407 Compare June 25, 2022 19:26
This was referenced Jun 25, 2022
Merged
Merged
Merged
Merged
Merged
@diosmosis diosmosis added the Needs Review PRs that need a code review label Jul 11, 2022
@diosmosis diosmosis marked this pull request as ready for review July 11, 2022 01:57
@github-actions
Copy link
Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Jul 18, 2022
@diosmosis diosmosis added the Do not close PRs with this label won't be marked as stale by the Close Stale Issues action label Jul 18, 2022
@github-actions github-actions bot removed the Stale The label used by the Close Stale Issues action label Jul 19, 2022
@github-actions
Copy link
Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions github-actions bot added Stale The label used by the Close Stale Issues action and removed Stale The label used by the Close Stale Issues action labels Jul 27, 2022
sgiehl
sgiehl requested changes Aug 1, 2022
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@diosmosis Only had a quick look at the UI yet, but it seems when switching the segment in the selector, the selector doesn't change it's value / highlight. Even though the segment seems to be loaded correctly.

plugins/SegmentEditor/templates/_segmentSelector.twig Show resolved Hide resolved
plugins/Morpheus/javascripts/piwikHelper.js Outdated Show resolved Hide resolved
@diosmosis
Copy link
Member Author

@sgiehl fixed the issue you mentioned. Did some more manual testing, but not a comprehensive test, and couldn't find anything else, but the Segmentation.js code can be confusing so it's very possible I missed something.

sgiehl
sgiehl approved these changes Aug 8, 2022
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now. Clicked through the UI and didn't find any further regressions.
The segment editor in custom reports won't work though until the PR to remove angular was merged there as well.

@sgiehl sgiehl merged commit 21c743f into 5.x-dev Aug 8, 2022
@sgiehl sgiehl deleted the vue-remove-angularjs-SegmentEditor branch August 8, 2022 12:59
@justinvelluppillai justinvelluppillai added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Sep 29, 2022
bx80 pushed a commit that referenced this pull request Nov 25, 2022
@diosmosis @sgiehl @bx80
[Vue] remove use of angularjs from SegmentEditor plugin (#19391)
0c3bf2d 
* remove use of angularjs from SegmentEditor plugin

* remove import added by phpstorm

* make sure to export comparison service instance not just class

* built vue files

* fixing some issues

* fix initial value for segment definition

* treat null, undefined and empty string segment value the same

* Update expected screenshots

* try to fix timing error in test

* remove use of html_attr escape

* adds missing translations

* remove unused code

* fix segment definition selection and fix Matomo URL watch in Segmentation.js

* fix test failure

Co-authored-by: sgiehl <stefan@matomo.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Do not close PRs with this label won't be marked as stale by the Close Stale Issues action Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@diosmosis @sgiehl @justinvelluppillai