Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vue] Remove use of angularjs from SitesManager plugin #19390

Merged
merged 9 commits into from Jul 28, 2022

Conversation

diosmosis
Copy link
Member

Description:

Changes:

  • Move siteWithoutTabs.twig content to new vue component.
  • Replace simple directive use in some twig templates with vue-directive use.
  • Introduce VueEntryContainer component for more convenient embedding of vue-entry from within other Vue components, primarily for compatibility w/ twig Template... events. (Note: Twig events like these should not be used this way in the future.)

Review

…ainer for more convenient embedding of vue-entry use from within other Vue components (primarily for supporting twig Template... events in Vue).
@diosmosis diosmosis added this to the 5.0.0 milestone Jun 23, 2022
@diosmosis diosmosis marked this pull request as draft June 23, 2022 00:21
@diosmosis diosmosis force-pushed the vue-remove-angularjs-SitesManager branch from 7bb1ffe to 6723bcc Compare June 28, 2022 19:55
@diosmosis diosmosis added the Needs Review PRs that need a code review label Jul 11, 2022
@diosmosis diosmosis marked this pull request as ready for review July 11, 2022 01:50
@github-actions
Copy link
Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Jul 18, 2022
@diosmosis diosmosis added the Do not close PRs with this label won't be marked as stale by the Close Stale Issues action label Jul 18, 2022
@github-actions github-actions bot removed the Stale The label used by the Close Stale Issues action label Jul 19, 2022
@github-actions
Copy link
Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions github-actions bot added Stale The label used by the Close Stale Issues action and removed Stale The label used by the Close Stale Issues action labels Jul 27, 2022
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work as expected. Also checked that vue components injected using the template events are rendered correctly 👍

@sgiehl sgiehl merged commit 7ec141f into 5.x-dev Jul 28, 2022
@sgiehl sgiehl deleted the vue-remove-angularjs-SitesManager branch July 28, 2022 07:23
@justinvelluppillai justinvelluppillai added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Sep 29, 2022
bx80 pushed a commit that referenced this pull request Nov 25, 2022
* Remove use of angularjs from SitesManager plugin and add VueEntryContainer for more convenient embedding of vue-entry use from within other Vue components (primarily for supporting twig Template... events in Vue).

* forgot to export

* built vue files

* fix ui test issues

* remove use of unneeded html_attr escape

Co-authored-by: sgiehl <stefan@matomo.org>
bx80 pushed a commit that referenced this pull request Nov 25, 2022
* Remove use of angularjs from SitesManager plugin and add VueEntryContainer for more convenient embedding of vue-entry use from within other Vue components (primarily for supporting twig Template... events in Vue).

* forgot to export

* built vue files

* fix ui test issues

* remove use of unneeded html_attr escape

Co-authored-by: sgiehl <stefan@matomo.org>
bx80 pushed a commit that referenced this pull request Nov 25, 2022
* Remove use of angularjs from SitesManager plugin and add VueEntryContainer for more convenient embedding of vue-entry use from within other Vue components (primarily for supporting twig Template... events in Vue).

* forgot to export

* built vue files

* fix ui test issues

* remove use of unneeded html_attr escape

Co-authored-by: sgiehl <stefan@matomo.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Do not close PRs with this label won't be marked as stale by the Close Stale Issues action Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants