New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Vue] Remove use of angularjs from SitesManager plugin #19390
Conversation
…ainer for more convenient embedding of vue-entry use from within other Vue components (primarily for supporting twig Template... events in Vue).
7bb1ffe
to
6723bcc
Compare
…-org/matomo into vue-remove-angularjs-SitesManager
This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers |
This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work as expected. Also checked that vue components injected using the template events are rendered correctly 👍
* Remove use of angularjs from SitesManager plugin and add VueEntryContainer for more convenient embedding of vue-entry use from within other Vue components (primarily for supporting twig Template... events in Vue). * forgot to export * built vue files * fix ui test issues * remove use of unneeded html_attr escape Co-authored-by: sgiehl <stefan@matomo.org>
* Remove use of angularjs from SitesManager plugin and add VueEntryContainer for more convenient embedding of vue-entry use from within other Vue components (primarily for supporting twig Template... events in Vue). * forgot to export * built vue files * fix ui test issues * remove use of unneeded html_attr escape Co-authored-by: sgiehl <stefan@matomo.org>
* Remove use of angularjs from SitesManager plugin and add VueEntryContainer for more convenient embedding of vue-entry use from within other Vue components (primarily for supporting twig Template... events in Vue). * forgot to export * built vue files * fix ui test issues * remove use of unneeded html_attr escape Co-authored-by: sgiehl <stefan@matomo.org>
Description:
Changes:
Template...
events. (Note: Twig events like these should not be used this way in the future.)Review