Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added translation keys for scope titles in custom dimensions #19385

Merged
merged 2 commits into from Jun 23, 2022
Merged

Added translation keys for scope titles in custom dimensions #19385

merged 2 commits into from Jun 23, 2022

Conversation

ulcuber
Copy link
Contributor

@ulcuber ulcuber commented Jun 22, 2022

Description:

Fixes hardcoded Dimensions titles on Websites -> Custom Dimensions settings page

Review

@sgiehl
Copy link
Member

sgiehl commented Jun 23, 2022

@ulcuber Thanks for creating this PR. It's required to also update the built vue files. You can easily trigger building the files by running ./console vue:build CustomDimensions

@sgiehl sgiehl added this to the 4.12.0 milestone Jun 23, 2022
@ulcuber
Copy link
Contributor Author

ulcuber commented Jun 23, 2022

@sgiehl thanks for clarifying. Added build files

@sgiehl
Copy link
Member

sgiehl commented Jun 23, 2022

@ulcuber Thanks for that. Will merge this once the tests ran through.

@sgiehl sgiehl merged commit 8fb129e into matomo-org:4.x-dev Jun 23, 2022
@justinvelluppillai justinvelluppillai changed the title Translation keys for scope titles in custom dimensions Added translation keys for scope titles in custom dimensions Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.12.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ulcuber @sgiehl