Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vue] remove use of angularjs from Transitions #19383

Merged
merged 15 commits into from Jul 27, 2022
Merged

[Vue] remove use of angularjs from Transitions #19383

merged 15 commits into from Jul 27, 2022

Conversation

diosmosis
Copy link
Member

Description:

Changes:

  • Move contents of transitions.twig to TransitionsPage.vue component.
  • Create TransitionExporterLink.vue component to initiate v-transition-exporter link w/o using an angularjs directive.
  • Remove use of angularjs services in transitions.js vanilla javascript file.

Review

@diosmosis
move transitions.twig contents to new vue component and create Transi…
c0a2af4 
…tionExporterLink component to use transition-exporter link in vue w/o angularjs directive
@diosmosis
do not use angularjs services in transitions.js
9e9371b
@diosmosis diosmosis added this to the 5.0.0 milestone Jun 22, 2022
@diosmosis diosmosis marked this pull request as draft June 23, 2022 02:11
@diosmosis diosmosis added the Needs Review PRs that need a code review label Jul 11, 2022
@diosmosis diosmosis marked this pull request as ready for review July 11, 2022 01:40
@github-actions
Copy link
Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Jul 18, 2022
@diosmosis diosmosis added the Do not close PRs with this label won't be marked as stale by the Close Stale Issues action label Jul 18, 2022
@github-actions github-actions bot removed the Stale The label used by the Close Stale Issues action label Jul 19, 2022
@github-actions
Copy link
Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions github-actions bot added Stale The label used by the Close Stale Issues action and removed Stale The label used by the Close Stale Issues action labels Jul 27, 2022
@sgiehl sgiehl merged commit 1869d8c into 5.x-dev Jul 27, 2022
@sgiehl sgiehl deleted the vue-remove-angularjs-transitions branch July 27, 2022 15:30
@justinvelluppillai justinvelluppillai added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Sep 29, 2022
bx80 pushed a commit that referenced this pull request Nov 25, 2022
@diosmosis @sgiehl @bx80
[Vue] remove use of angularjs from Transitions (#19383)
d575686 
* move transitions.twig contents to new vue component and create TransitionExporterLink component to use transition-exporter link in vue w/o angularjs directive

* do not use angularjs services in transitions.js

* built vue files

* fixing some issues

* add alternative way for widget twig templates to tell CoreHome/Controller.php that it contains its own content block

* built vue files

* allow vue components in popups and remove console log

* update screenshots

* remove use of unneeded html_attr filter

* updates expected test files

Co-authored-by: sgiehl <stefan@matomo.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Do not close PRs with this label won't be marked as stale by the Close Stale Issues action Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@diosmosis @sgiehl @justinvelluppillai