@diosmosis opened this Pull Request on June 22nd 2022 Member

Description:

This PR is based off of #18846.

Changes:

  • Create vue components for loginTwoFactorAuth.twig, setupFinished.twig, showRecoveryCodes.twig, userSettings.twig.
  • Unify setupTwoFactorAuth/setupTwoFactorAuthStandalone.
  • Create vue component for Login/formErrors.twig (since it's used directly in TwoFactorAuth).

Review

@github-actions[bot] commented on July 18th 2022 Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@sgiehl commented on July 26th 2022 Member

@diosmosis This one needs a rebase / merge.

@diosmosis commented on July 27th 2022 Member

@sgiehl merged w/ 5.x-dev

@sgiehl commented on July 27th 2022 Member

@diosmosis are all the changes to Login and UsersManager plugin supposed to be in this PR or is it maybe based on anther PR as the description says?

@diosmosis commented on July 27th 2022 Member

@sgiehl the Login changes are meant to be, the UsersManager changes came from https://github.com/matomo-org/matomo/pull/19378. The PR linked in the description is meant to be that PR, but I must have picked the wrong one in the dropdown github displays. Apologies.

@sgiehl commented on July 27th 2022 Member

Reviewed and merged the other one. Guess this one needs another merge now 🙈

@diosmosis commented on July 28th 2022 Member

@sgiehl merged :+1:. Thanks for making small fixes in the other PR!

@diosmosis commented on July 28th 2022 Member

@sgiehl committed the suggestions, thanks for the catching those

This Pull Request was closed on August 17th 2022
Powered by GitHub Issue Mirror