New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Vue] remove use of angularjs from TwoFactorAuth plugin #19382
Conversation
…ularjs adapters and modify less styles that use directive attribute names
…ew vue components and add vue component for Logins formErrors.twig template
…o-org/matomo into vue-remove-angularjs-users-manager
…ularjs-TwoFactorAuth
…o-org/matomo into vue-remove-angularjs-TwoFactorAuth
…ularjs-TwoFactorAuth
…ularjs-TwoFactorAuth
@sgiehl merged 👍. Thanks for making small fixes in the other PR! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments for improvements / fixes. Besides that it looks good. Clicked through the Login and 2FA setup and everything seems to work correctly.
plugins/TwoFactorAuth/vue/src/LoginTwoFactorAuth/LoginTwoFactorAuth.vue
Outdated
Show resolved
Hide resolved
plugins/TwoFactorAuth/vue/src/ShowRecoveryCodes/ShowRecoveryCodesPage.vue
Outdated
Show resolved
Hide resolved
…rAuth.vue Co-authored-by: Stefan Giehl <stefan@matomo.org>
Co-authored-by: Stefan Giehl <stefan@matomo.org>
…desPage.vue Co-authored-by: Stefan Giehl <stefan@matomo.org>
Co-authored-by: Stefan Giehl <stefan@matomo.org>
@sgiehl committed the suggestions, thanks for the catching those |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems there are still some tests failing. otherwise looks good
…o-org/matomo into vue-remove-angularjs-TwoFactorAuth
* convert twig templates using directives to vue components, remove angularjs adapters and modify less styles that use directive attribute names * built vue files * move use of angularjs directives in TwoFactorAuth twig templates to new vue components and add vue component for Logins formErrors.twig template * built vue files * add missing translations * fixing UI tests * more UI test fixex * remove reference to nonexistant JS file * updated expected screenshots * fixing ui test failures * update expected screenshots * fixing ui test failures * fix select on focus use * fix placement of computed property * fixing ui test issues * prevent random failure * make sure Login plugin UMD is always loaded * formErrors is an object if supplied * compile vue entry components in reset API response and modify check for success * rebuild login * update expected screenshot * remove unneeded use of html_attr escape * remove use of html_attr and remove duplicate client side translation token entries * sort used js translations and remove duplicates * Update plugins/TwoFactorAuth/vue/src/LoginTwoFactorAuth/LoginTwoFactorAuth.vue Co-authored-by: Stefan Giehl <stefan@matomo.org> * Update plugins/TwoFactorAuth/vue/src/UserSettings/UserSettings.vue Co-authored-by: Stefan Giehl <stefan@matomo.org> * Update plugins/TwoFactorAuth/vue/src/ShowRecoveryCodes/ShowRecoveryCodesPage.vue Co-authored-by: Stefan Giehl <stefan@matomo.org> * Update plugins/TwoFactorAuth/vue/src/SetupFinished/SetupFinished.vue Co-authored-by: Stefan Giehl <stefan@matomo.org> * built vue files * adds missing sanitize * fix AssetManagerTest * try to fix issue with umd asset fetching if Login not loaded * cs * updates expected test files Co-authored-by: sgiehl <stefan@matomo.org>
* convert twig templates using directives to vue components, remove angularjs adapters and modify less styles that use directive attribute names * built vue files * move use of angularjs directives in TwoFactorAuth twig templates to new vue components and add vue component for Logins formErrors.twig template * built vue files * add missing translations * fixing UI tests * more UI test fixex * remove reference to nonexistant JS file * updated expected screenshots * fixing ui test failures * update expected screenshots * fixing ui test failures * fix select on focus use * fix placement of computed property * fixing ui test issues * prevent random failure * make sure Login plugin UMD is always loaded * formErrors is an object if supplied * compile vue entry components in reset API response and modify check for success * rebuild login * update expected screenshot * remove unneeded use of html_attr escape * remove use of html_attr and remove duplicate client side translation token entries * sort used js translations and remove duplicates * Update plugins/TwoFactorAuth/vue/src/LoginTwoFactorAuth/LoginTwoFactorAuth.vue Co-authored-by: Stefan Giehl <stefan@matomo.org> * Update plugins/TwoFactorAuth/vue/src/UserSettings/UserSettings.vue Co-authored-by: Stefan Giehl <stefan@matomo.org> * Update plugins/TwoFactorAuth/vue/src/ShowRecoveryCodes/ShowRecoveryCodesPage.vue Co-authored-by: Stefan Giehl <stefan@matomo.org> * Update plugins/TwoFactorAuth/vue/src/SetupFinished/SetupFinished.vue Co-authored-by: Stefan Giehl <stefan@matomo.org> * built vue files * adds missing sanitize * fix AssetManagerTest * try to fix issue with umd asset fetching if Login not loaded * cs * updates expected test files Co-authored-by: sgiehl <stefan@matomo.org>
* convert twig templates using directives to vue components, remove angularjs adapters and modify less styles that use directive attribute names * built vue files * move use of angularjs directives in TwoFactorAuth twig templates to new vue components and add vue component for Logins formErrors.twig template * built vue files * add missing translations * fixing UI tests * more UI test fixex * remove reference to nonexistant JS file * updated expected screenshots * fixing ui test failures * update expected screenshots * fixing ui test failures * fix select on focus use * fix placement of computed property * fixing ui test issues * prevent random failure * make sure Login plugin UMD is always loaded * formErrors is an object if supplied * compile vue entry components in reset API response and modify check for success * rebuild login * update expected screenshot * remove unneeded use of html_attr escape * remove use of html_attr and remove duplicate client side translation token entries * sort used js translations and remove duplicates * Update plugins/TwoFactorAuth/vue/src/LoginTwoFactorAuth/LoginTwoFactorAuth.vue Co-authored-by: Stefan Giehl <stefan@matomo.org> * Update plugins/TwoFactorAuth/vue/src/UserSettings/UserSettings.vue Co-authored-by: Stefan Giehl <stefan@matomo.org> * Update plugins/TwoFactorAuth/vue/src/ShowRecoveryCodes/ShowRecoveryCodesPage.vue Co-authored-by: Stefan Giehl <stefan@matomo.org> * Update plugins/TwoFactorAuth/vue/src/SetupFinished/SetupFinished.vue Co-authored-by: Stefan Giehl <stefan@matomo.org> * built vue files * adds missing sanitize * fix AssetManagerTest * try to fix issue with umd asset fetching if Login not loaded * cs * updates expected test files Co-authored-by: sgiehl <stefan@matomo.org>
Description:
This PR is based off of #18846.
Changes:
Review