Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vue] remove angularjs use from UserCountry #19381

Merged
merged 13 commits into from Jul 28, 2022
Merged

[Vue] remove angularjs use from UserCountry #19381

merged 13 commits into from Jul 28, 2022

Conversation

diosmosis
Copy link
Member

Description:

Changes:

  • Make the Sparkline.vue component work more like the sparkline macro (adding width/height params, allow supplying a string URL + make sure loading attribute is set the same).
  • Move getDistinctCountries.twig and adminIndex.twig contents to two new Vue components.

Review

@diosmosis diosmosis added this to the 5.0.0 milestone Jun 21, 2022
@diosmosis diosmosis marked this pull request as draft June 21, 2022 23:16
@diosmosis diosmosis added the Needs Review PRs that need a code review label Jul 11, 2022
@diosmosis diosmosis marked this pull request as ready for review July 11, 2022 01:21
@github-actions
Copy link
Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Jul 18, 2022
@diosmosis diosmosis added the Do not close PRs with this label won't be marked as stale by the Close Stale Issues action label Jul 18, 2022
@github-actions github-actions bot removed the Stale The label used by the Close Stale Issues action label Jul 19, 2022
@github-actions
Copy link
Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions github-actions bot added Stale The label used by the Close Stale Issues action and removed Stale The label used by the Close Stale Issues action labels Jul 27, 2022
sgiehl
sgiehl requested changes Jul 27, 2022
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment. Otherwise looks good.

plugins/CoreHome/vue/src/Sparkline/Sparkline.vue Show resolved Hide resolved
@sgiehl sgiehl removed the Needs Review PRs that need a code review label Jul 27, 2022
@sgiehl sgiehl merged commit 9c5d215 into 5.x-dev Jul 28, 2022
@sgiehl sgiehl deleted the vue-remove-angularjs-UserCountry branch July 28, 2022 09:49
@justinvelluppillai justinvelluppillai added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Sep 29, 2022
bx80 pushed a commit that referenced this pull request Nov 25, 2022
@diosmosis @sgiehl @bx80
[Vue] remove angularjs use from UserCountry (#19381)
bc6885d 
* make Sparkline component work more like sparkline twig macro

* move contents of twig templates that use angularjs to vue components

* built vue files

* add missing translations

* update expected screenshots

* fix numeric conversion

* remove use of html_attr and remove duplicate translation tokens

* add explicit height/width to match dimensions before for distinct countries

* update expected screenshots

Co-authored-by: sgiehl <stefan@matomo.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Do not close PRs with this label won't be marked as stale by the Close Stale Issues action not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@diosmosis @sgiehl @justinvelluppillai