Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vue] remove use of piwik-enriched-headline in UserLanguage #19379

Merged
merged 5 commits into from Jul 27, 2022
Merged

[Vue] remove use of piwik-enriched-headline in UserLanguage #19379

merged 5 commits into from Jul 27, 2022

Conversation

diosmosis
Copy link
Member

Description:

As title.

Review

@diosmosis diosmosis added this to the 5.0.0 milestone Jun 21, 2022
@diosmosis diosmosis marked this pull request as draft June 21, 2022 21:51
@diosmosis diosmosis marked this pull request as ready for review July 11, 2022 00:55
@diosmosis diosmosis added the Needs Review PRs that need a code review label Jul 11, 2022
@github-actions
Copy link
Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Jul 18, 2022
@diosmosis diosmosis added the Do not close PRs with this label won't be marked as stale by the Close Stale Issues action label Jul 18, 2022
@github-actions github-actions bot removed the Stale The label used by the Close Stale Issues action label Jul 21, 2022
sgiehl
sgiehl requested changes Jul 26, 2022
View reviewed changes
plugins/UserLanguage/UserLanguage.php Outdated Show resolved Hide resolved
@sgiehl sgiehl removed the Needs Review PRs that need a code review label Jul 26, 2022
@diosmosis diosmosis added the Needs Review PRs that need a code review label Jul 27, 2022
@diosmosis
Copy link
Member Author

@sgiehl removed

@sgiehl sgiehl merged commit c0ced3f into 5.x-dev Jul 27, 2022
@sgiehl sgiehl deleted the vue-remove-angularjs-UserLanguage branch July 27, 2022 07:06
@sgiehl sgiehl removed the Needs Review PRs that need a code review label Jul 27, 2022
@justinvelluppillai justinvelluppillai added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Sep 29, 2022
bx80 pushed a commit that referenced this pull request Nov 25, 2022
@diosmosis @sgiehl @bx80
[Vue] remove use of piwik-enriched-headline in UserLanguage (#19379)
6a141a8 
* remove use of piwik-enriched-headline in UserLanguage

* remove obsolete event handler

* remove unused use statements

Co-authored-by: Stefan Giehl <stefan@matomo.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl requested changes

Assignees
No one assigned
Labels
Do not close PRs with this label won't be marked as stale by the Close Stale Issues action not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@diosmosis @sgiehl @justinvelluppillai