Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vue] remove use of angularjs from UsersManager plugin #19378

Merged
merged 16 commits into from Jul 27, 2022
Merged

[Vue] remove use of angularjs from UsersManager plugin #19378

merged 16 commits into from Jul 27, 2022

Conversation

diosmosis
Copy link
Member

Description:

Changes:

  • Convert twig templates with angularjs use to vue components (AddNewToken.vue, AddNewTokenSuccess.vue, UserSecurity.vue, UserSettings.vue).
  • Remove angularjs adapters.
  • Modify some less styles that use directive attributes to select.

Please include a description of this change and which issue it fixes. If no issue exists yet please include context and what problem it solves.

Review

@diosmosis
convert twig templates using directives to vue components, remove ang…
da62746 
…ularjs adapters and modify less styles that use directive attribute names
@diosmosis diosmosis added this to the 5.0.0 milestone Jun 21, 2022
@diosmosis diosmosis marked this pull request as draft June 21, 2022 21:50
@diosmosis diosmosis marked this pull request as ready for review July 11, 2022 00:54
@diosmosis diosmosis added the Needs Review PRs that need a code review label Jul 11, 2022
@github-actions
Copy link
Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Jul 21, 2022
@diosmosis diosmosis mentioned this pull request Jul 27, 2022
Merged
11 tasks
sgiehl
sgiehl approved these changes Jul 27, 2022
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed a couple of tiny fixes. Now everything seems to work as expected.

@sgiehl sgiehl merged commit b76bdae into 5.x-dev Jul 27, 2022
@sgiehl sgiehl deleted the vue-remove-angularjs-users-manager branch July 27, 2022 13:53
@justinvelluppillai justinvelluppillai added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Sep 29, 2022
bx80 pushed a commit that referenced this pull request Nov 25, 2022
@diosmosis @sgiehl @bx80
[Vue] remove use of angularjs from UsersManager plugin (#19378)
ff9cd18 
* convert twig templates using directives to vue components, remove angularjs adapters and modify less styles that use directive attribute names

* built vue files

* add missing translations

* fixing UI tests

* more UI test fixex

* updated expected screenshots

* update expected screenshots

* fix select on focus use

* remove unneeded use of html_attr escape

* fix exports

* updates expected test files

* adds missing sanitize

Co-authored-by: sgiehl <stefan@matomo.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Stale The label used by the Close Stale Issues action
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@diosmosis @sgiehl @justinvelluppillai