Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vue] remove angularjs use (except ng-app directive) from Widgetize plugin #19376

Merged
merged 3 commits into from Jul 26, 2022

Conversation

diosmosis
Copy link
Member

Description:

Changes:

  • Remove piwik-popover-handler directive (no longer exists).
  • Remove unused adapter.

Review

@diosmosis diosmosis added this to the 5.0.0 milestone Jun 21, 2022
@diosmosis diosmosis marked this pull request as draft June 21, 2022 19:41
@diosmosis diosmosis added the Needs Review PRs that need a code review label Jul 11, 2022
@diosmosis diosmosis marked this pull request as ready for review July 11, 2022 00:49
@github-actions
Copy link
Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Jul 21, 2022
@sgiehl sgiehl merged commit 1191a90 into 5.x-dev Jul 26, 2022
@sgiehl sgiehl deleted the vue-remove-angularjs-widgetize branch July 26, 2022 13:20
@justinvelluppillai justinvelluppillai added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Stale The label used by the Close Stale Issues action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants