Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vue] rework input value reset that allows parent component to disallow change #19375

Merged
merged 1 commit into from Jun 23, 2022

Conversation

diosmosis
Copy link
Member

Description:

Instead of resetting modelValue before sending update:modelValue, res…et after if modelValue has not changed so cursor change will only happen if change is disallowed.

Fixes #19303

Review

…et after if modelValue has not changed so cursor change will only happen if change is disallowed
@diosmosis diosmosis added the Needs Review PRs that need a code review label Jun 21, 2022
@diosmosis diosmosis added this to the 4.12.0 milestone Jun 21, 2022
@sgiehl sgiehl merged commit 3fcac56 into 4.x-dev Jun 23, 2022
@sgiehl sgiehl deleted the vue-19303-different-order-model-reset branch June 23, 2022 07:38
@diosmosis diosmosis mentioned this pull request Jul 11, 2022
@justinvelluppillai justinvelluppillai added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI/UX regressions in global website settings
3 participants