[Vue] Make sure default value for modelValue in SiteSelector is reflected in v-model value. #19369
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When null/undefined is used as the v-model value for SiteSelector, SiteSelector sets a default value. But this is not reflected in v-model since the update:modelValue event is not called, leaving the parent component's v-model value still set to undefined/null.
This PR makes sure the default value is set through update:modelValue.
It also adds a new property
defaultToFirstSite
that allows defaulting the modelValue to the first site in the queried lists. This can't be done by default in case it needs to be possible to unset the value to null. (I'm not sure if that's currently possible, though.)Review