Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vue] when getting plugin path relative to webroot, try all possible webroots #19362

Merged
merged 5 commits into from Jun 21, 2022
Merged

[Vue] when getting plugin path relative to webroot, try all possible webroots #19362

merged 5 commits into from Jun 21, 2022

Conversation

diosmosis
Copy link
Member

Description:

As title.

Review

@diosmosis
Copy link
Member Author

latest version shown to work on matomo for wordpress

@diosmosis diosmosis added the Needs Review PRs that need a code review label Jun 16, 2022
@diosmosis diosmosis added this to the 4.12.0 milestone Jun 16, 2022
@AltamashShaikh AltamashShaikh mentioned this pull request Jun 16, 2022
Closed
@sgiehl
Copy link
Member

sgiehl commented Jun 20, 2022

@diosmosis would you mind rebasing this one onto next_release. We still haven't released the final 4.11. So might be good to include that one, so it can make it into matomo for wordpress soon.

@sgiehl sgiehl modified the milestones: 4.12.0, 4.11.0 Jun 20, 2022
@diosmosis diosmosis changed the base branch from 4.x-dev to next_release June 20, 2022 15:43
@diosmosis
Copy link
Member Author

@sgiehl done

@sgiehl sgiehl merged commit a6b8786 into next_release Jun 21, 2022
@sgiehl sgiehl deleted the vue-alternative-webroots branch June 21, 2022 07:40
@sgiehl sgiehl removed the Needs Review PRs that need a code review label Jun 21, 2022
@justinvelluppillai justinvelluppillai added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AltamashShaikh AltamashShaikh AltamashShaikh left review comments

@peterhashair peterhashair peterhashair approved these changes

@sgiehl sgiehl Awaiting requested review from sgiehl

Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.11.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@diosmosis @sgiehl @peterhashair @AltamashShaikh @justinvelluppillai